swift
[5.2] [Typechecker] Fix _modify for wrapped properties with observers
#30994

Merged

[5.2] [Typechecker] Fix _modify for wrapped properties with observers #30994

tkremenek merged 10 commits into swiftlang:swift-5.2-branch from fix/SR-12178_5.2

[Typechecker] Wrapped properties with observers should not have ReadW…

f087a688

[Typechecker] Supress _modify synthesis if the wrapped property has o…

035bc16e

[Test] Add an executable test

00b7f80a

[Typechecker] Add an hasObservers() convenience method and simplify s…

4b6350e4

[Typechecker] Simplify StorageImplInfo code in finishPropertyWrapperI…

47742772

[Test] Add a SILGen test to make sure the observers are correctly called

8a049d02

theblixguy requested a review 5 years ago

[Typechecker] Add missing 'storageReadWriteImpl' variable in 'synthes…

fa1370ea

[Typechecker] Tweak property wrapper mutability computation a bit

57bc6195

[Test] Update a SILGen test which relies on oldValue not being fetched

a422a1e2

[Typechecker] Return 'None' if TargetImpl isn't Wrapper or WrapperSto…

30ad8d07

tkremenek approved these changes on 2020-04-16

tkremenek merged 49e70edc into swift-5.2-branch 5 years ago

theblixguy deleted the fix/SR-12178_5.2 branch 5 years ago

AnthonyLatsis added swift 5.2

AnthonyLatsis added 🍒 release cherry pick

AnthonyLatsis removed swift 5.2

Reviewers

tkremenek

Assignees

No one assigned

Labels

🍒 release cherry pick

Milestone

No milestone