[IDE] Fix another GenericFunctionType subst crasher #38503
hamishknight
merged
2 commits into
swiftlang:main
from
hamishknight:another-one-bites-the-subst
[IDE] Use method result type for getTypeOfMember call
73027925
[AST] Reject GenericFunctionType in TypeBase::getTypeOfMember
d4c25f55
slavapestov
approved these changes
on 2021-07-20
hamishknight4 years ago
@swift-ci please test source compatibility
hamishknight4 years ago
@swift-ci please test
rintaro
approved these changes
on 2021-07-20
Login to write a write a comment.
When matching methods for the conforming types SourceKit request, we were using the method's interface type in a call to
TypeBase::getTypeOfMember, which could lead to crashes when callingsubstwith a GenericFunctionType. Instead, pass the result type only, as that's all we want anyway.Then change
TypeBase::getTypeOfMemberto enforce that a GenericFunctionType isn't passed as thememberTypeparameter to avoid other callers making the same mistake.rdar://77259607