swift
Provide doc comments for AsyncStream/AsyncThrowingStream
#38535
Merged
Overview
Commits
21
Changes
View On GitHub

Provide doc comments for AsyncStream/AsyncThrowingStream #38535

najacque merged 21 commits into release/5.5-08092021 from asyncstream_doc_comments_80515639
invalidname
First draft of doc comments for AsyncStream.
91537c06
Source docs for AsyncThrowingStream.
db293aef
Async(Throwing)Stream style fixups.
f6e3df8f
Style fixes to Async(Throwing)Stream docs.
771b22df
Correct parameter name in AsyncStream doc comments
d5ff5eee
Improve code snippet in AsyncThrowingStream docs.
be6d7618
invalidname invalidname assigned parkera parkera 4 years ago
invalidname invalidname assigned phausler phausler 4 years ago
invalidname invalidname assigned amartini51 amartini51 4 years ago
invalidname invalidname requested a review 4 years ago
invalidname invalidname assigned bendjones bendjones 4 years ago
harlanhaskins
harlanhaskins commented on 2021-07-23
heckj
heckj commented on 2021-07-23
heckj
heckj commented on 2021-07-23
amartini51
amartini51 requested changes on 2021-07-23
invalidname Apply Alex's suggestions from code review
cf123b8a
invalidname Apply Joe H's suggestions from code review
949c357e
invalidname Apply Harlan's suggestions from code review
003b013d
Fix duplicate words in doc comment.
4d8efaab
Address more of @amartini51's doc feedback.
83624efe
Reflow code snippet in doc comment.
8201bdae
Use multiple trailing closures in doc snippet.
e6a2e175
phausler
phausler commented on 2021-07-27
Apply some doc comment feedback from @phausler.
ba14cf6c
Correct note syntax for AsyncStream doc comments.
3e3538b2
Update code snippet in docs for AsyncStream.init
3ed8f9f4
Add AsyncStream.Continuation escaping note.
6b621466
invalidname invalidname changed the base branch from release/5.5 to release/5.5-08092021 4 years ago
chuckdude
chuckdude requested changes on 2021-08-17
invalidname Apply Chuck's suggestions from code review
c11034c4
Apply edits to Async(Throwing)Stream doc comments.
5ce6d8fb
chuckdude
chuckdude approved these changes on 2021-08-18
Docs: make explicit that stream closure uses steps
b1d2e240
chuckdude
chuckdude commented on 2021-08-20
chuckdude
chuckdude approved these changes on 2021-08-20
amartini51 Incorporate spelling & wording fixes from editorial review.
717d5c60
amartini51
amartini51 approved these changes on 2021-08-23
amartini51
swift-ci
shahmishal
najacque
najacque approved these changes on 2021-08-25
najacque najacque merged 83fa59de into release/5.5-08092021 4 years ago
najacque najacque deleted the asyncstream_doc_comments_80515639 branch 4 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum