swift
[CMake] Add SWIFT_STDLIB_SHORT_MANGLING_LOOKUPS to StandaloneOverlay
#40311
Merged

[CMake] Add SWIFT_STDLIB_SHORT_MANGLING_LOOKUPS to StandaloneOverlay #40311

edymtt
edymtt3 years ago (edited 3 years ago)

This will allow it to have a sensible default in configurations that use it.

Addresses rdar://85815655

edymtt [CMake] Add SWIFT_STDLIB_SHORT_MANGLING_LOOKUPS to StandaloneOverlay
8a8127fe
edymtt edymtt requested a review from DougGregor DougGregor 3 years ago
edymtt edymtt requested a review from kubamracek kubamracek 3 years ago
edymtt
edymtt3 years ago

@swift-ci Please Build Toolchain macOS Platform

edymtt
edymtt3 years ago

@swift-ci please smoke test

swift-ci
swift-ci3 years ago

macOS Toolchain
Download Toolchain
Git Sha - 8a8127f

Install command
tar -zxf swift-PR-40311-1221-osx.tar.gz --directory ~/

kubamracek
kubamracek approved these changes on 2021-11-30
kubamracek
kubamracek3 years ago👍 1

As an immediate fix, LGTM.

Though we should really find a way to avoid this from happening in the future, either enforce StandaloneOverlay.cmake and stdlib/CMakeLists.txt being in sync, or including one from the other or something like that.

edymtt edymtt merged 5b8714e0 into main 3 years ago
edymtt edymtt deleted the add-short-mangling-option-to-standalone-overlay branch 3 years ago
edymtt
edymtt3 years ago

Working on proper long term fix in #40610

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone