Fix var-parameter detection for inferred params #4980
tkremenek
merged
1 commit into
swiftlang:swift-3.0-branch
from
harlanhaskins:var-you-sure-about-that-swift-3.0-branch
harlanhaskins8 years ago
- Explanation: We've removed the 'var' modifier from function parameters in Swift 3, but the diagnostic for that is only emitted when we have a valid type loc. With inferred closure parameters, you're allowed to specify a parameter without a type. If you leave 'var' on one of those, it causes an assertion in SILGen. Instead, teach the diagnostic to handle omitted types.
- Scope: Only affects function parameters with elided types.
- Issue: SR-2562
- Reviewed by: @DougGregor and @CodaFi
- Risk: Low.
- Testing: Added a test to cover this diagnostic.
harlanhaskins8 years ago
@swift-ci please test
swift-ci8 years ago
Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 80f67ae6582c522f1c172d193d7fdfbb19acff61
Test requested by - @harlanhaskins
swift-ci8 years ago
Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 80f67ae6582c522f1c172d193d7fdfbb19acff61
Test requested by - @harlanhaskins
harlanhaskins8 years ago
There is a crasher that no longer crashes. I'll move it.
Fix var-parameter detection for inferred params
1bfee7b2
harlanhaskins8 years ago
@swift-ci please test
tkremenek8 years ago
@swift-ci clean test
Login to write a write a comment.