swift
[CodeCompletion] Enable SwiftParser parsing for code completion
#65078
Merged

[CodeCompletion] Enable SwiftParser parsing for code completion #65078

rintaro
rintaro2 years ago (edited 2 years ago)

Enable SwiftParser parsing for code completion, but disable the roundtrip/validation testing. So that macro expansions are correctly performed in code completion, while avoiding an assertion failure
caused by existence of null character in the source buffer.

rdar://107900870

rintaro rintaro requested a review from ahoppen ahoppen 2 years ago
rintaro rintaro requested a review from bnbarham bnbarham 2 years ago
rintaro rintaro requested a review from CodaFi CodaFi 2 years ago
rintaro rintaro requested a review from DougGregor DougGregor 2 years ago
rintaro rintaro force pushed from 9ca4ef68 to 53d1a2b3 2 years ago
rintaro
rintaro2 years ago

@swift-ci Please test

bnbarham
bnbarham approved these changes on 2023-04-11
ahoppen
ahoppen approved these changes on 2023-04-11
tools/swift-ide-test/swift-ide-test.cpp
4495 if (!options::LoadPluginLibrary.empty()) {
4496 std::vector<std::string> paths;
4497 for (auto path: options::LoadPluginLibrary) {
4498
llvm::errs() << "LoadPluginLibrary: " << path << "\n";
ahoppen2 years ago

Was this just debug output during development or do you want to keep it for the future?

rintaro2 years ago

Argh, I will remove this.

rintaro [swift-ide-test] Add plugin related options
96ff0e2c
rintaro [Parse] Enable SwiftParser parisng for code completion
f9feee6b
rintaro rintaro force pushed from 53d1a2b3 to f9feee6b 2 years ago
rintaro
rintaro2 years ago

@swift-ci Please smoke test

rintaro rintaro merged 153c9d27 into main 2 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone