swift
[TaskGroup] Fix unlock order, add missing detaches and add more assertions
#67590

Merged

[TaskGroup] Fix unlock order, add missing detaches and add more assertions #67590

swift-ci merged 13 commits into swiftlang:main from ktoso:wip-multi-error-group-single-leak

ktoso requested a review from

kavon 2 years ago

ktoso commented on 2023-07-28

ktoso requested a review from

al45tair 2 years ago

ktoso force pushed from a54bd196 to 9fecd4bc 2 years ago

ktoso commented on 2023-08-08

ktoso changed the title ~~[DiscardingTaskGroup] Properly detach when LAST task is failed, and prior failure was already stored~~ [TaskGroup] Fix unlock order, add missing detaches and add more assertions 2 years ago

ktoso marked this pull request as draft 2 years ago

reenable async_taskgroup_discarding_dontLeak.swift

0116b095

[DiscardingTaskGroup] Properly detach when LAST task is failed, and p…

9d9f8cb1

[TaskGroup] Must detach discarded task, THEN unlock before resume wai…

b135ecd8

revamping locking scheme, test this a bunch

61d783c5

stabilize println based test a bit more against timing

00f674bb

re-enable tsan test: async_taskgroup_next

34f8da36

reenable async_taskgroup_next_on_pending

0cc31cab

disable debugging tricks

383c62f7

unlock test: async_taskgroup_asynciterator_semantics

376a9a80

make use of unreachable

060260e9

ktoso force pushed from 7e233082 to 060260e9 2 years ago

ktoso commented on 2023-08-09

cleanups

7d93bba7

ktoso force pushed from 33e15ba3 to 7d93bba7 2 years ago

cleanup for freestanding mode

8aa70dc7

ktoso marked this pull request as ready for review 2 years ago

ktoso requested a review from

mikeash 2 years ago

ktoso added concurrency runtime

al45tair approved these changes on 2023-08-09

mikeash approved these changes on 2023-08-09

Review feedback: add better code comments

11959556

swift-ci merged 9668f044 into main 2 years ago

ktoso deleted the wip-multi-error-group-single-leak branch 2 years ago

Reviewers

mikeash

al45tair

kavon

Assignees

No one assigned

Labels

concurrency runtime

Milestone

No milestone

swift [TaskGroup] Fix unlock order, add missing detaches and add more assertions #67590 Merged

[TaskGroup] Fix unlock order, add missing detaches and add more assertions #67590

swift
[TaskGroup] Fix unlock order, add missing detaches and add more assertions
#67590

Merged