Don't delete allocations in DCE #73852
meg-gupta
merged
1 commit into
swiftlang:main
from
meg-gupta:fixdce
meg-gupta1 year ago
Fixes issue reported in #73768
meg-gupta1 year ago
@swift-ci test
atrick
approved these changes
on 2024-05-23
atrick1 year ago👍 1
LGTM. Could you add a comment and CHECK lines to the test?
meg-gupta1 year ago
@swift-ci smoke test
Don't delete allocations in DCE
505d84fe
meg-gupta1 year ago
@swift-ci smoke test
turbolent1 year ago
Thank you for the quick fix @meg-gupta 🙏
Login to write a write a comment.
DCE was deleting an allocation with only destroy_value users. This isn't correct when the deinit can have a side effect. This should be handled in DeadObjectElimination which does additional analysis on deinit to determine if a dead allocation can be eliminated.