swift
Deinit-Devirtualization: fix a crash when trying to de-virtualize a non-copyable generic
#74474
Merged

Deinit-Devirtualization: fix a crash when trying to de-virtualize a non-copyable generic #74474

eeckstein
eeckstein1 year ago

rdar://129980818

eeckstein Deinit-Devirtualization: fix a crash when trying to de-virtualize a n…
715a765b
eeckstein
eeckstein1 year ago

@swift-ci smoke test

slavapestov
slavapestov commented on 2024-06-17
SwiftCompilerSources/Sources/Optimizer/Utilities/Devirtualization.swift
3535 }
36 precondition(type.isNominal, "non-copyable non-nominal types not supported, yet")
36
37 if !type.isNominal {
38
// E.g. a non-copyable generic function parameter
slavapestov1 year ago

This comment confuses me. Is a Copyable generic parameter “nominal”?

eeckstein1 year ago

I mean, e.g. func foo<T: ~Copyable>(_ t: T). T is not copyable and not a nominal type

eeckstein eeckstein merged ee65ebb5 into main 1 year ago
eeckstein eeckstein deleted the fix-deinit-devirt branch 1 year ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone