swift
utils: pin the latest build for ARM64 to bootstrap on Windows
#75104
Merged

utils: pin the latest build for ARM64 to bootstrap on Windows #75104

compnerd merged 1 commit into swiftlang:main from compnerd:pinning
compnerd
compnerd1 year ago

We need a bootstrapping toolchain. Now that we have an ARM64 build for Windows, pin that to provide a default pinned toolchain. This should allow us to build natively on Windows ARM64 without having to specify the download image ourselves.

compnerd utils: pin the latest build for ARM64 to bootstrap on Windows
b4f2f498
compnerd compnerd requested a review from hyp hyp 1 year ago
compnerd compnerd requested a review from shahmishal shahmishal 1 year ago
compnerd compnerd requested a review from hjyamauchi hjyamauchi 1 year ago
compnerd
compnerd1 year ago

@swift-ci please test

hjyamauchi
hjyamauchi approved these changes on 2024-07-09
compnerd compnerd requested a review from etcwilde etcwilde 1 year ago
etcwilde
etcwilde commented on 2024-07-09
etcwilde1 year ago

I'm fine with pinning it, though I'd like confirmation that someone tried out the pinned toolchain and made sure that it's viable and produces binaries without crashing before approving. I don't have an arm64 windows box to test with unfortunately.

This should allow us to build natively on Windows ARM64

Does this mean you've tried it and it worked or that it looks like it should work?

compnerd
compnerd1 year ago👍 1

I'm fine with pinning it, though I'd like confirmation that someone tried out the pinned toolchain and made sure that it's viable and produces binaries without crashing before approving. I don't have an arm64 windows box to test with unfortunately.

Yes, the pinned ARM64 toolchain was smoke tested and does generate working binaries.

Does this mean you've tried it and it worked or that it looks like it should work?

I do not have a ARM64 machine capable of building the toolchain. Perhaps someone at Apple can do that under parallels if we want to test this particular revision of the toolchain? The native ARM64 toolchain build path has been tested by @hjyamauchi repeatedly though.

etcwilde
etcwilde approved these changes on 2024-07-09
etcwilde1 year ago

The native ARM64 toolchain build path has been tested by @hjyamauchi repeatedly though.

Good enough for me.

hjyamauchi
hjyamauchi1 year ago

Also the pinned toolchain is used during the CI build so if it doesn't work the CI should fail.

compnerd compnerd merged 31fc0a65 into main 1 year ago
compnerd compnerd deleted the pinning branch 1 year ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone