swift
[cxx-interop] Flip the default value of `SWIFT_ENABLE_EXPERIMENTAL_CXX_INTEROP`
#75173

Merged

[cxx-interop] Flip the default value of `SWIFT_ENABLE_EXPERIMENTAL_CXX_INTEROP` #75173

egorzhdan merged 1 commit into main from egorzhdan/cxx-interop-cmake-option-default

egorzhdan1 year ago

This changes the default value of the CMake flag SWIFT_ENABLE_EXPERIMENTAL_CXX_INTEROP from FALSE to TRUE.

C++ interop is an important part of the compiler. If necessary, it's still possible to disable it explicitly.

[cxx-interop] Flip the default value of `SWIFT_ENABLE_EXPERIMENTAL_CX…

33cd18b0

egorzhdan added c++ interop

egorzhdan1 year ago

@swift-ci please test

egorzhdan1 year ago

@swift-ci please build toolchain Windows

egorzhdan1 year ago

@swift-ci please test macOS

egorzhdan1 year ago

@swift-ci please smoke test macOS

egorzhdan requested a review from

compnerd 1 year ago

egorzhdan marked this pull request as ready for review 1 year ago

egorzhdan requested a review from

Xazax-hun 1 year ago

compnerd approved these changes on 2024-07-12

compnerd1 year ago

Flipping the default here makes sense with the use of Swift in the compiler now.

egorzhdan1 year ago

@swift-ci please smoke test macOS

compnerd1 year ago

@swift-ci please smoke test macOS

Xazax-hun approved these changes on 2024-07-15

egorzhdan1 year ago

The macOS test failure is unrelated, I'm merging this.

egorzhdan merged 08b4f3ae into main 1 year ago

egorzhdan deleted the egorzhdan/cxx-interop-cmake-option-default branch 1 year ago

Reviewers

Xazax-hun

compnerd

Assignees

No one assigned

Labels

c++ interop

Milestone

No milestone