@swift-ci Please smoke test
@swift-ci Please test source compatibility
1 | 1 | // RUN: %scale-test --invert-result --begin 1 --end 5 --step 1 --select NumLeafScopes %s | |
2 | 2 | ||
3 | // REQUIRES: no_asan |
Other tests have tools-release
, I think we should add to all of these new test-cases too because I think tests are flaky in non-release configuration.
Hi @slavapestov the windows rebranch CI started to fail: https://ci-external.swift.org/job/swift-rebranch-windows-toolchain/515/consoleText
Failed Tests (6):
Swift(windows-x86_64) :: Concurrency/async_overload_filtering.swift
Swift(windows-x86_64) :: Constraints/common_type.swift
Swift(windows-x86_64) :: Constraints/init_literal_via_coercion.swift
Swift(windows-x86_64) :: Constraints/one_way_solve.swift
Swift(windows-x86_64) :: Constraints/overload_filtering.swift
Swift(windows-x86_64) :: Constraints/result_builder_conjunction_selection.swift
Could this #77152 from https://ci-external.swift.org/job/swift-rebranch-windows-toolchain/515/changes#58a6a64647aeb270897241d6b229c1ffe17c37dd
be causing it? Sorry if I'm mistaken as I'm not familiar with the constraints :)
CC @bnbarham
Thanks for the fix @slavapestov
Login to write a write a comment.
When we retire a constraint, there is no guarantee that it is at the end of the list, so it is not correct to always reinsert it at the end of the list when the constraint comes out of retirement. Instead, remember the position where we removed it from, so that we can always reinsert it in the correct position. This allows us to replace some bespoke logic in CSStep.h with a call to
retireConstraint()
.Fixes #77008
Also fixes rdar://problem/138246764