swift
[AST] Remove `ModuleDecl::addFile`
#77666
Merged

[AST] Remove `ModuleDecl::addFile` #77666

hamishknight
hamishknight235 days ago (edited 235 days ago)

Rather than exposing an addFile member on ModuleDecl, have the create members take a lambda that populates the files for the module. Once module construction has finished, the files are immutable.

hamishknight hamishknight force pushed from 4924074c to 7cadaf9e 235 days ago
hamishknight hamishknight force pushed from 7cadaf9e to 67ba1337 235 days ago
hamishknight hamishknight changed the title [DNM] [AST] Remove `ModuleDecl::addFile` [AST] Remove `ModuleDecl::addFile` 235 days ago
hamishknight Factor out ModuleDecl overload of import resolution
e2ba36f7
hamishknight [IDE] Avoid relying on after-the-fact use of `addFile`
309c0241
hamishknight [AST] Remove `ModuleDecl::addFile`
4946c799
hamishknight hamishknight force pushed from 67ba1337 to 4946c799 234 days ago
hamishknight
hamishknight234 days ago
hamishknight
hamishknight234 days ago

swiftlang/llvm-project#9618

@swift-ci please test source compatibility

hamishknight hamishknight marked this pull request as ready for review 234 days ago
hamishknight hamishknight requested a review from hborla hborla 234 days ago
hamishknight hamishknight requested a review from xedin xedin 234 days ago
hamishknight hamishknight requested a review from slavapestov slavapestov 234 days ago
hamishknight hamishknight requested a review from ahoppen ahoppen 234 days ago
hamishknight hamishknight requested a review from bnbarham bnbarham 234 days ago
hamishknight hamishknight requested a review from rintaro rintaro 234 days ago
hamishknight hamishknight requested a review from artemcm artemcm 234 days ago
hamishknight hamishknight requested a review from xymus xymus 234 days ago
hamishknight hamishknight requested a review from CodaFi CodaFi 234 days ago
hamishknight hamishknight requested a review from DougGregor DougGregor 234 days ago
hamishknight hamishknight requested a review from rjmccall rjmccall 234 days ago
hamishknight hamishknight requested a review from tshortli tshortli 234 days ago
hamishknight hamishknight requested a review from adrian-prantl adrian-prantl 234 days ago
hamishknight hamishknight requested a review from zoecarver zoecarver 234 days ago
hamishknight hamishknight requested a review from hyp hyp 234 days ago
hamishknight hamishknight requested a review from egorzhdan egorzhdan 234 days ago
hamishknight hamishknight requested a review from beccadax beccadax 234 days ago
hamishknight hamishknight requested a review from ian-twilightcoder ian-twilightcoder 234 days ago
hamishknight hamishknight requested a review from Xazax-hun Xazax-hun 234 days ago
DougGregor
DougGregor approved these changes on 2024-11-19
DougGregor232 days ago

Nice cleanup, no notes

hamishknight
hamishknight231 days ago
rintaro
rintaro approved these changes on 2024-11-21
hamishknight hamishknight merged 23e3f5f5 into main 230 days ago
hamishknight hamishknight deleted the lets-try-this-again branch 230 days ago

Login to write a write a comment.

Login via GitHub