CastOptimizer: handle isolated conformances #80543
eeckstein
merged
4 commits into
swiftlang:main
from
eeckstein:isolated-conformance-opt
eeckstein78 days ago
@swift-ci smoke test
DougGregor
commented
on 2025-04-04
lib/SIL/Utils/DynamicCasts.cpp
| 117 | 117 | // requirements were satisfied. | |
| 118 | if (checkConformance(source, TargetProtocol)) | ||
| 118 | if (auto conformance = checkConformance(source, TargetProtocol)) { | ||
| 119 | if (conformance.isConcrete()) { | ||
| 120 | if (!matchesActorIsolation(conformance.getConcrete(), function)) | ||
| 121 | return DynamicCastFeasibility::MaySucceed; |
DougGregor78 days ago👍 1You also need to check whether any conditional requirements have been satisfied by isolated conformances here. ProtocolConformanceRef::forEachIsolatedConformance knows how to enumerate all of the isolated conformances, including those satisfying conditional requirements. You could build on that determine the isolation of a given ProtocolConformanceRef and use that instead of the isConcrete check.
lib/SIL/Utils/DynamicCasts.cpp
| 881 | 888 | return DynamicCastFeasibility::WillFail; | |
| 882 | 889 | } | |
| 883 | 890 | ||
| 891 | bool swift::matchesActorIsolation(ProtocolConformance *conformance, SILFunction *inFunction) { |
DougGregor78 days ago👍 1Per the previous comment, I recommend passing a ProtocolConformanceRef in here so the callers don't do the isConcrete/getConcrete dance.
eeckstein78 days ago
@swift-ci smoke test
DougGregor
approved these changes
on 2025-04-04
DougGregor78 days ago
Looks great with these changes
SIL: add `matchesActorIsolation`
9df10393
CastOptimizer: pass the SIL function to the cast-classify APIs, inste…
e18bedaa
CastOptimizer: handle isolated conformances
75a0cc03
Simplification: check for isolated conformances when simplifying meta…
f5ca12d4
eeckstein77 days ago
@swift-ci smoke test
Login to write a write a comment.
Check the isolation of conformances to avoid wrong folding of dynamic casts
rdar://147417762