swift
Fix two issues related with emission of differentiability witnesses
#80983
Open
@swift-ci please test
Linux build seems to be broken due to unrelated issue:
... lib/libFoundationInternationalization.so lib/libFoundationEssentials.so lib/lib_FoundationCollections.a lib/lib_FoundationCShims.a lib/lib_FoundationICU.so /home/build-user/build/buildbot_linux/libdispatch-linux-x86_64/libswiftDispatch.so /home/build-user/build/buildbot_linux/libdispatch-linux-x86_64/libdispatch.so /home/build-user/build/buildbot_linux/libdispatch-linux-x86_64/libBlocksRuntime.so -lgcc -lgcc_s -lc -lgcc -lgcc_s && :
error: link command failed with exit code 1 (use -v to see invocation)
Sources/plutil/CMakeFiles/plutil.dir/PLUContext_KeyPaths.swift.o:main.swift.o:function $sSS6plutilE19escapedKeyPathSplitSaySSGyF: error: undefined reference to '$sSy12RegexBuilderSs11SubSequenceRtzrlE5split9separator9maxSplits25omittingEmptySubsequencesSaySsGSS_SiSbtF'
Windows too:
FAILED: bin/FoundationInternationalization.dll lib/FoundationInternationalization.lib
C:\Windows\system32\cmd.exe /C "cd . && T:\5\bin\swiftc.exe -target x86_64-unknown-windows-msvc -j 36 -num-threads 36 -emit-library -sdk "T:/Program Files/Swift/Platforms/Windows.platform/Developer/SDKs/Windows.sdk" -gnone -Xlinker /INCREMENTAL:NO -Xlinker /OPT:REF -Xlinker /OPT:ICF -O -libc MD -Xlinker -implib:lib\FoundationInternationalization.lib -o bin\FoundationInternationalization.dll @CMakeFiles\FoundationInternationalization.rsp && cd ."
<unknown>:0: warning: using (deprecated) legacy driver, Swift installation does not contain swift-driver at: 'C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\build\5\bin\swift-driver-new.exe'
Creating library lib\FoundationInternationalization.lib and object lib\FoundationInternationalization.exp
ICUDateFormatter.swift.obj : error LNK2019: unresolved external symbol __imp_$sSy12RegexBuilderSs11SubSequenceRtzrlE5split9separator9maxSplits25omittingEmptySubsequencesSaySsGSS_SiSbtF referenced in function $s20FoundationEssentials4DateV0A20InternationalizationE11FormatStyleV0C15FieldCollectionV14updateScheduleAD16ICUDateFormatterC0cE4InfoV06UpdateJ0Ovg
ICUDateFormatter.swift.obj : error LNK2019: unresolved external symbol __imp_$sSS17_StringProcessing14RegexComponent0C7BuilderMc referenced in function $sS2S17_StringProcessing14RegexComponent0C7BuilderWl
Duration+UnitsFormatStyle.swift.obj : error LNK2001: unresolved external symbol __imp_$sSS17_StringProcessing14RegexComponent0C7BuilderMc
TimeZone_ICU.swift.obj : error LNK2001: unresolved external symbol __imp_$sSS17_StringProcessing14RegexComponent0C7BuilderMc
@swift-ci please test
@swift-ci please test
@swift-ci please test
@swift-ci please test windows platform
@swift-ci please test windows platform
I'm running into this one more often nowadays. Would be great if we could move this PR forward. Is there anything left to do to make the windows tests pass?
@JaapWijnen windows was just broken on main IIRC.
@swift-ci please test windows platform
@swift-ci please test
@swift-ci please test macos platform
@swift-ci please test macos platform
I'd love to get this merged and perhaps we can still cherry pick this into 6.2? @clackary
@eeckstein @jckarter Any objections on this PR?
@swift-ci please test
@swift-ci please test
@swift-ci please test windows platform
@eeckstein @jckarter ping
Ensure we create differentiability witness when the closure is specia…
Drop differentiability witnesses for dead functions for which bodies …
Emit differentiability witness originating from custom derivative dec…
Add tests
Try to pacify Windows
Typo
@swift-ci please test
Login to write a write a comment.
@differentiableattribute or from explicit@derivative(of:)attribute on the derivative. In the latter case the derivative itself might not be emitted, while original function is (e.g. original function is@inlineable, but derivative is@usableFromInline). Previously both cases were handled only when function body was emitted. As a result we missed witness in the aforementioned case. Ensure the differentiability witness originating from@derivative(of:)is emitted even if we're not going to emit body of the derivative.Fixes #59135