swift
FreeBSD: Link C++ runtimes when Cxx interop is enabled
#82355

Merged

FreeBSD: Link C++ runtimes when Cxx interop is enabled #82355

etcwilde merged 3 commits into swiftlang:main from etcwilde:ewilde/fbsd-cxx-interop-runtime

etcwilde61 days ago👍 1

This patch gets all of the C++ interop tests passing on FreeBSD. There were two bugs.

First, the Swift tests use the old Swift driver, which only used the experimental C++ interop flag to determine whether or not to use clang++ or clang. Changing the legacy driver to align more closely with the behavior of the Swift driver:

      var cxxCompatEnabled = parsedOptions.hasArgument(.enableExperimentalCxxInterop)
      if let cxxInteropMode = parsedOptions.getLastArgument(.cxxInteroperabilityMode) {
        if cxxInteropMode.asSingle != "off" {
          cxxCompatEnabled = true
        }
      }
      // ...
      let clangTool: Tool = cxxCompatEnabled ? .clangxx : .clang
      // ...

https://github.com/swiftlang/swift-driver/blob/1670905e1a74a31379470bc4947e123ab21923a4/Sources/SwiftDriver/Jobs/GenericUnixToolchain%2BLinkerSupport.swift#L82-L87

Second, there were several tests that didn't pass the flag to the driver, but to the frontend, so that didn't fix all of the tests. The tests passing it to the frontend are relying on the autolink mechanism to automatically pull in a C++ runtime and an overlay. A separate patch adds FreeBSD to the list of OS's to automatically link the C++ runtime when C++ interop is enabled.

Third, this isn't fixing bugs, but just enabling a handful of tests that are passing but were marked unsupported.

Use C++ driver when C++ interop is enabled

33767856

FreeBSD: Autolink C++ runtime

91aa7b88

FreeBSD: Enable a few more C++ interop tests

3a48d6e9

etcwilde added FreeBSD

etcwilde requested a review from