Allow row column for equality delete #25729
weijiii
wants to merge
1 commit into
trinodb:master
from
weijiii:fix-iceberg-eq-delete-constraint
Allow row column for equality delete
f5153363
chenjian2664
commented
on 2025-05-08
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
| 298 | public void testV2TableWithEqualityDeleteWhenColumnIsRow() | ||
| 299 | throws Exception | ||
| 300 | { | ||
| 301 | String tableName = "test_v2_equality_delete_column_is_row" + randomNameSuffix(); |
chenjian266416 days ago👍 1Could you please add more test cases?
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/delete/TrinoRow.java
| 158 | @Override | ||
| 159 | public <T> void set(int i, T t) | ||
| 160 | { | ||
| 161 | throw new UnsupportedOperationException("Testing StructLike does not support setting values."); |
chenjian266416 days agoPlease update the exception message
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/delete/TrinoRow.java
| 60 | 83 | return "TrinoRow" + Arrays.toString(values); | |
| 61 | 84 | } | |
| 85 | |||
| 86 | static Object getObjectValue(ConnectorSession session, Block block, int position, Type type) |
chenjian266416 days agoCan we move this logic to IcebergPageSink, maybe an overload with getIcebergValue, or even maybe we could extract a util
Login to write a write a comment.
Reviewers
Assignees
No one assigned
Labels
cla-signed
iceberg
Milestone
No milestone
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: