next.js
Fix issue where layout-router wouldn't auto-scroll if we imported styles or fonts
#45487
Merged
Overview
Commits
27
Changes
View On GitHub

Fix issue where layout-router wouldn't auto-scroll if we imported styles or fonts #45487

jankaifer merged 27 commits into vercel:canary from jankaifer:jankaifer/next-378-next-13-navigation-with-link-does-not
jankaifer
jankaifer refactor test to use createNextDescribe
437d2a74
jankaifer add reproduction
e3357baf
jankaifer remove debug changes
d8068591
jankaifer move page itself before css imports like css or fonts
4f23455c
jankaifer jankaifer requested a review from timneutkens timneutkens 2 years ago
jankaifer jankaifer requested a review from ijjk ijjk 2 years ago
jankaifer jankaifer requested a review from shuding shuding 2 years ago
jankaifer jankaifer requested a review from huozhi huozhi 2 years ago
jankaifer jankaifer requested a review from feedthejim feedthejim 2 years ago
ijjk ijjk added created-by: Next.js team
ijjk ijjk added type: next
jankaifer jankaifer changed the title refactor test to use createNextDescribe Fix issue where layout-router wouldn't auto-scroll if we imported styles or fonts 2 years ago
jankaifer add comment into code
4f199b55
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
09256eaa
ijjk
ijjk
jankaifer jankaifer marked this pull request as draft 2 years ago
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
b62f2fa3
jankaifer Revert "move page itself before css imports like css or fonts"
c6498d84
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
6ee5fb6f
jankaifer Make sure we render the page component before font preconnect/preload…
1b7e8f56
jankaifer jankaifer marked this pull request as ready for review 2 years ago
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
5a0d49b0
guitheengineer
guitheengineer commented on 2023-02-02
jankaifer added comment about our findDOMNode hack in app-render.tsx
4e225837
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
64b5f4df
jankaifer jankaifer enabled auto-merge (squash) 2 years ago
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
3a12468e
jankaifer refactor test to make it immune to changes of order of font includes
a6b65753
jankaifer
disabled auto-merge 2 years ago
Manually disabled by user
jankaifer jankaifer marked this pull request as draft 2 years ago
jankaifer fix order of font files in tests
d3b3c169
jankaifer remove Set due to non-determinism
803848c1
jankaifer readded sorting in tests
9c4e26de
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
218e693a
jankaifer fix tests to match sorted links
58be36bc
jankaifer
jankaifer jankaifer marked this pull request as ready for review 2 years ago
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
4091450e
timneutkens
timneutkens dismissed these changes on 2023-02-06
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
d4f6a2e8
jankaifer jankaifer enabled auto-merge (squash) 2 years ago
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
4b51696c
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
28b62be8
jankaifer jankaifer dismissed their stale review via 28b62be8 2 years ago
jankaifer jankaifer requested a review from timneutkens timneutkens 2 years ago
timneutkens
timneutkens commented on 2023-02-07
jankaifer changed back to Set with sorting to deduplicate items
62532635
timneutkens
timneutkens approved these changes on 2023-02-07
jankaifer Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
ba2da69a
kodiakhq[bot] Merge branch 'canary' into jankaifer/next-378-next-13-navigation-with…
b3eb5b71
jankaifer jankaifer merged 3827d8fb into canary 2 years ago
jankaifer jankaifer deleted the jankaifer/next-378-next-13-navigation-with-link-does-not branch 2 years ago
github-actions github-actions locked as resolved and limited conversation to collaborators 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
type: next created-by: Next.js team
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum