next.js
Fix(typedRoutes): fixed StaticRoutes and DynamicRoutes being empty causing invalid syntax
#46620

Merged

Fix(typedRoutes): fixed StaticRoutes and DynamicRoutes being empty causing invalid syntax #46620

kodiakhq merged 6 commits into vercel:canary from canhdu:ducanhgh-fix-typed-routes-empty

Fix(typedRoutes): fixed StaticRoutes and DynamicRoutes being empty ca…

24a4861e

DuCanhGH requested a review from

timneutkens 3 years ago

DuCanhGH requested a review from

ijjk 3 years ago

DuCanhGH requested a review from

shuding 3 years ago

DuCanhGH requested a review from

huozhi 3 years ago

DuCanhGH requested a review from

feedthejim 3 years ago

ijjk added type: next

DuCanhGH marked this pull request as draft 3 years ago

moved fallback

b2cb7fd5

DuCanhGH marked this pull request as ready for review 3 years ago

removed RouteImpl's fallback since it isn't necessary

1d49fbd7

shuding commented on 2023-03-01

using OR instead of variables

402ec63c

fix: 'string', not ''

407b68d4

Merge branch 'canary' into ducanhgh-fix-typed-routes-empty

5f0b20d5

shuding approved these changes on 2023-03-01

ijjk approved these changes on 2023-03-01

kodiakhq merged fcfab172 into canary 3 years ago

github-actions locked as resolved and limited conversation to collaborators 3 years ago

DuCanhGH deleted the ducanhgh-fix-typed-routes-empty branch 2 years ago

Reviewers

ijjk

shuding

timneutkens

huozhi

feedthejim

Assignees

No one assigned

Labels

type: next

Milestone

No milestone