next.js
fix(eslint): `next/script` `beforeInteractive` gives warning on appDir
#51148
Merged
Overview
Commits
13
Changes
View On GitHub

fix(eslint): `next/script` `beforeInteractive` gives warning on appDir #51148

kodiakhq merged 13 commits into vercel:canary from feat/fix-appdir-eslint-beforeinteractive
devjiwonchoi
fix: eslint beforeinteractive not ignore appDir
b1ebcca6
ijjk ijjk added type: next
ghost ghost requested a review from ijjk ijjk 3 years ago
ijjk
ijjk
devjiwonchoi devjiwonchoi changed the title fix: eslint beforeinteractive not ignore appDir fix: eslint beforeinteractive not ignore appDir - Fixes #46609 3 years ago
Merge branch 'canary' into feat/fix-appdir-eslint-beforeinteractive
551bed3b
devjiwonchoi
ijjk
ijjk commented on 2023-06-14
chore: modify test
33a43f82
devjiwonchoi devjiwonchoi requested a review from ijjk ijjk 2 years ago
shuding Merge branch 'canary' into feat/fix-appdir-eslint-beforeinteractive
141d4aa0
shuding shuding requested a review from timneutkens timneutkens 2 years ago
shuding shuding requested a review from shuding shuding 2 years ago
shuding shuding requested a review from huozhi huozhi 2 years ago
shuding shuding requested a review from feedthejim feedthejim 2 years ago
ijjk
improve getting root dir path
d481a7d7
refactor managing pathname
b90d3974
ijjk ijjk added area: tests
refactor: simplified checking file in app dir
9dad1e33
test: add test to validate separators and src/
f43ee385
test: remove unnecessary test cases
e24e71e5
chore: add type to `str` param
f43d2b72
timneutkens timneutkens changed the title fix: eslint beforeinteractive not ignore appDir - Fixes #46609 fix: eslint beforeinteractive not ignore appDir 2 years ago
timneutkens
timneutkens commented on 2023-07-06
fix: add path.sep in front of `app/`
7db3c43a
devjiwonchoi devjiwonchoi requested a review from timneutkens timneutkens 2 years ago
devjiwonchoi devjiwonchoi changed the title fix: eslint beforeinteractive not ignore appDir fix: eslint for beforeInteractive is not being ignored in /app 2 years ago
devjiwonchoi Merge branch 'canary' into feat/fix-appdir-eslint-beforeinteractive
d0a7b9da
devjiwonchoi devjiwonchoi requested a review from ztanner ztanner 2 years ago
devjiwonchoi devjiwonchoi requested a review from wyattjoh wyattjoh 2 years ago
devjiwonchoi devjiwonchoi changed the title fix: eslint for beforeInteractive is not being ignored in /app fix(eslint): `next/script` `beforeInteractive` gives warning on appDir 2 years ago
devjiwonchoi
timneutkens
timneutkens approved these changes on 2023-11-12
timneutkens Merge branch 'canary' into feat/fix-appdir-eslint-beforeinteractive
22a9e203
timneutkens timneutkens added CI approved
devjiwonchoi
kodiakhq kodiakhq merged 022cb256 into canary 2 years ago
devjiwonchoi devjiwonchoi deleted the feat/fix-appdir-eslint-beforeinteractive branch 2 years ago
github-actions github-actions added locked
github-actions github-actions locked as resolved and limited conversation to collaborators 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
type: next locked
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum