next.js
fix: `normalize-asset-prefix` adding leading slash when URL `assetPrefix` is provided
#68518

Merged

fix: `normalize-asset-prefix` adding leading slash when URL `assetPrefix` is provided #68518

devjiwonchoi merged 3 commits into canary from 08-05-fix_normalize_asset_prefix_for_socket_if_start_with_http

ijjk added created-by: Next.js team

ijjk added type: next

devjiwonchoi marked this pull request as ready for review 1 year ago

devjiwonchoi requested a review from

ijjk 1 year ago

devjiwonchoi requested a review from

eps1lon 1 year ago

devjiwonchoi force pushed to 409d532e 1 year ago

eps1lon commented on 2024-08-05

devjiwonchoi commented on 2024-08-05

devjiwonchoi changed the title ~~fix: normalize asset prefix for socket if start with http~~ fix: `normalize-asset-prefix` not properly handling URL `assetPrefix` 1 year ago

devjiwonchoi changed the title ~~fix: `normalize-asset-prefix` not properly handling URL `assetPrefix`~~ fix: `normalize-asset-prefix` adding leading slash when URL `assetPrefix` is provided 1 year ago

devjiwonchoi requested a review from

eps1lon 1 year ago

ijjk approved these changes on 2024-08-05

devjiwonchoi force pushed from d8aa85a4 1 year ago

devjiwonchoi force pushed 1 year ago

test: add test for normalized-asset-prefix (#68519)

dc1088ae

devjiwonchoi force pushed to c721b8c2 1 year ago

devjiwonchoi commented on 2024-08-06

devjiwonchoi marked this pull request as draft 1 year ago

fix: normalize asset prefix for socket if start with http

38d17daf

test: normalize-asset-prefix should return url if is url

240f468e

devjiwonchoi force pushed from 7b64dc74 to 240f468e 1 year ago

devjiwonchoi marked this pull request as ready for review 1 year ago

eps1lon approved these changes on 2024-08-06

devjiwonchoi merged a5e2a02f into canary 1 year ago

devjiwonchoi deleted the 08-05-fix_normalize_asset_prefix_for_socket_if_start_with_http branch 1 year ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 1 year ago

Reviewers

eps1lon

ijjk

Assignees

No one assigned

Labels

type: next created-by: Next.js team locked

Milestone

No milestone

next.js fix: `normalize-asset-prefix` adding leading slash when URL `assetPrefix` is provided #68518 Merged

fix: `normalize-asset-prefix` adding leading slash when URL `assetPrefix` is provided #68518

next.js
fix: `normalize-asset-prefix` adding leading slash when URL `assetPrefix` is provided
#68518

Merged