PR #71241 feat(turbopack): Implement module walking for side effect optimization

ijjk added created-by: Turbopack team

kdy1 changed the title ~~Prepare `select_part`~~ feat(turbopack): Implement side effect optimization 1 year ago

kdy1 force pushed to e596fc1c 1 year ago

kdy1 force pushed from a6326536 1 year ago

kdy1 changed the base branch from kdy1/ts-opt-module-eval to kdy1/ts-analysis-part 1 year ago

kdy1 force pushed 1 year ago

sokra commented on 2024-10-14

kdy1 force pushed 1 year ago

Base automatically changed from kdy1/ts-analysis-part to canary 1 year ago

kdy1 force pushed to d327fef9 1 year ago

kdy1 force pushed from 6535bf7c 1 year ago

kdy1 changed the base branch from canary to kdy1/ts-follow-exports 1 year ago

kdy1 marked this pull request as ready for review 1 year ago

kdy1 marked this pull request as draft 1 year ago

kdy1 force pushed 1 year ago

kdy1 changed the base branch from kdy1/ts-follow-exports to kdy1/ts-skip-partial-eval 1 year ago

kdy1 force pushed 1 year ago

kdy1 changed the base branch from kdy1/ts-skip-partial-eval to kdy1/ts-fix-default-module 1 year ago

kdy1 force pushed 1 year ago

kdy1 force pushed to a112a37a 1 year ago

kdy1 force pushed from a112a37a 1 year ago

sokra commented on 2024-10-17

kdy1 force pushed 1 year ago

kdy1 changed the base branch from kdy1/ts-fix-default-module to kdy1/ts-skip-partial-eval 1 year ago

kdy1 force pushed to 5b73f05c 1 year ago

kdy1 force pushed from 5b73f05c 1 year ago

kdy1 force pushed to 03ab4e02 1 year ago

kdy1 force pushed from 03ab4e02 1 year ago

kdy1 force pushed to 479e1975 1 year ago

kdy1 force pushed from 479e1975 1 year ago

kdy1 force pushed 1 year ago

kdy1 force pushed to 850d9bb7 1 year ago

kdy1 changed the base branch from kdy1/ts-skip-partial-eval to kdy1/ts-fix-default-module 1 year ago

kdy1 assigned

kdy1 1 year ago

kdy1 force pushed from 850d9bb7 1 year ago

kdy1 force pushed 1 year ago

kdy1 force pushed to ae6de306 1 year ago

kdy1 force pushed from ae6de306 to c96fdd78 1 year ago

kdy1 force pushed from c96fdd78 1 year ago

vercel deleted a comment from ijjk on 2024-10-31

kdy1 force pushed to 2673da62 1 year ago

kdy1 changed the base branch from kdy1/ts-fix-default-module to kdy1/ts-skip-partial-eval 1 year ago

kdy1 force pushed from 2673da62 to 3fe42a7e 1 year ago

kdy1 force pushed from 64abee05 1 year ago

kdy1 added CI Bypass Graphite Optimization

kdy1 force pushed 1 year ago

kdy1 force pushed to 4f63594b 1 year ago

kdy1 force pushed from 4f63594b to fd58ad7d 1 year ago

kdy1 force pushed from fd58ad7d 1 year ago

kdy1 changed the base branch from kdy1/ts-skip-partial-eval to graphite-base/71241 1 year ago

kdy1 force pushed 1 year ago

kdy1 changed the base branch from graphite-base/71241 to canary 1 year ago

kdy1 force pushed 1 year ago

sokra commented on 2024-11-07

vercel deleted a comment from ijjk on 2024-11-07

kdy1 force pushed to 99f1b3b6 1 year ago

kdy1 force pushed from 99f1b3b6 to 3cd50d3d 1 year ago

kdy1 force pushed from a706bb0b 1 year ago

kdy1 force pushed to 42a65e03 1 year ago

kdy1 force pushed to 6fe86b2c 1 year ago

Prepare `select_part`

c69163d3

Remove dbg

325bac6a

Update turbopack/crates/turbopack-ecmascript/src/references/esm/expor…

cd9eb516

Preserve side effects using `SideEffectsModule`

5efec058

[TMP] Add logging for side effect nodes

dde4d510

Fix `follow_reexports` for original case

a7bf6df5

Revert chganges in `follow_reexports`

38c399e0

Fix resolving issues

b3a2ab7b

Fix `follow_reexports_with_side_effects`

0bd6263c

impl EcmascriptChunkPlaceable for SideEffectsModule

bdf93bfc

Declare a chunk item for `SideEffectsModule`

d85c2a3d

Chunk item

ef227df7

We need to implement it manually

f9b1d6eb

trivial impls

485c1966

wrap_module_part_asset

2023694f

new_name

b9140045

Rename field

4c4fd1bf

order

96bf7e4f

Fix `SideEffectsModule::ident`

cbe54e04

modifier

c25ef0fa

return original if no side effect

d830b357

cleanup

7454c17d

only_effects

340466b3

need_await

8bac483e

cleanup

cc6d01fd

fix build

746a5044

[TRY] Eager drop of references

552ca7e9

Remove variant related codes

475190c0

Fix lints

3a742d05

Improve `SideEffectsModule::ident()`

da42e00d

Use original module ident

a1ad0615

Rename fields

b5c5582b

SingleChunkableModuleReference

f527368d

Done

66345c2c

kdy1 force pushed from 6fe86b2c to 66345c2c 1 year ago

Remove hack

ba2b3b46

revert

0ee59457

review feedback

cf779a18

is_marked_as_side_effect_free

903a1d81

Fix test by using a hack

a9959e65

Split file

6c80e234

No vc

7c679f2a

kdy1 commented on 2024-11-18

kdy1 requested a review from

sokra 1 year ago

kdy1 marked this pull request as ready for review 1 year ago

pub

80f6d06e

kdy1 marked this pull request as draft 1 year ago

kdy1 marked this pull request as ready for review 1 year ago

kdy1 marked this pull request as draft 1 year ago

Remove hack

8ea90fbd

Disable cargo test

06966898

kdy1 marked this pull request as ready for review 1 year ago

select_part

a4ee9269

sokra requested changes on 2024-11-18

kdy1 force pushed to 9a209c36 1 year ago

kdy1 force pushed from 9a209c36 to a4ee9269 1 year ago

kdy1 changed the title ~~feat(turbopack): Implement side effect optimization~~ feat(turbopack): Implement side effect optimization partially 1 year ago

kdy1 requested a review from

sokra 1 year ago

kdy1 commented on 2024-11-19

kdy1 changed the title ~~feat(turbopack): Implement side effect optimization partially~~ feat(turbopack): Implement module walking for side effect optimization 1 year ago

sokra approved these changes on 2024-11-19

kdy1 merged a8f1c707 into canary 1 year ago

kdy1 deleted the kdy1/ts-reexport-all branch 1 year ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 1 year ago

next.js
feat(turbopack): Implement module walking for side effect optimization
#71241

Merged

feat(turbopack): Implement module walking for side effect optimization #71241

next.js feat(turbopack): Implement module walking for side effect optimization #71241 Merged

feat(turbopack): Implement module walking for side effect optimization #71241

next.js
feat(turbopack): Implement module walking for side effect optimization
#71241

Merged