next.js
feat(after): wait for after-callbacks before server shutdown
#72590
Merged

feat(after): wait for after-callbacks before server shutdown #72590

lubieowoce
ijjk ijjk added created-by: Next.js team
ijjk ijjk added tests
ijjk ijjk added type: next
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce force pushed to 585c54d2 1 year ago
ijjk
ijjk
lubieowoce lubieowoce force pushed from 585c54d2 1 year ago
lubieowoce lubieowoce force pushed to 153e1221 1 year ago
lubieowoce lubieowoce requested a review from wyattjoh wyattjoh 1 year ago
lubieowoce lubieowoce marked this pull request as ready for review 1 year ago
lubieowoce lubieowoce changed the title feat(after): wait for callbacks before `next start` exits feat(after): wait for after-callbacks before server shutdown 1 year ago
wyattjoh
wyattjoh commented on 2024-11-15
lubieowoce lubieowoce force pushed from f32a60c8 to 9be6084a 1 year ago
lubieowoce lubieowoce force pushed from 60ab4571 to 1e39bcb7 1 year ago
lubieowoce lubieowoce force pushed from 1e39bcb7 1 year ago
lubieowoce lubieowoce changed the base branch from canary to lubieowoce/no-duplicate-custom-server 1 year ago
lubieowoce
lubieowoce
lubieowoce commented on 2024-11-21
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce force pushed to d7427240 1 year ago
lubieowoce lubieowoce force pushed from d7427240 1 year ago
lubieowoce lubieowoce force pushed to 62811ffa 1 year ago
lubieowoce lubieowoce changed the base branch from lubieowoce/no-duplicate-custom-server to graphite-base/72590 1 year ago
lubieowoce lubieowoce force pushed from 62811ffa 1 year ago
lubieowoce lubieowoce changed the base branch from graphite-base/72590 to canary 1 year ago
lubieowoce lubieowoce force pushed to af218037 1 year ago
lubieowoce lubieowoce force pushed from af218037 1 year ago
lubieowoce lubieowoce requested a review from wyattjoh wyattjoh 1 year ago
wyattjoh
wyattjoh commented on 2024-11-25
lubieowoce lubieowoce requested a review from wyattjoh wyattjoh 1 year ago
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce enabled auto-merge (squash) 1 year ago
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce force pushed to a1fc4a85 1 year ago
lubieowoce lubieowoce force pushed 1 year ago
lubieowoce lubieowoce force pushed to cd24f236 1 year ago
lubieowoce lubieowoce force pushed from cd24f236 1 year ago
lubieowoce lubieowoce force pushed 1 year ago
wyattjoh
wyattjoh commented on 2024-11-27
lubieowoce wip
6313d67d
lubieowoce move server cleanups to .close()
7a055e6e
lubieowoce clarify some comments
879f37a9
lubieowoce onDevServerCleanup
4101de4c
lubieowoce only create cleanupListeners if necessary
416d31bc
lubieowoce dev behavior for custom server
623cd238
lubieowoce try to fix custom server
79740fcd
lubieowoce debug logging
d9e7c7f5
lubieowoce fix: don't skip NextNodeServer.cleanup in dev
8d6799c9
lubieowoce test: exclude custom server test from deployment tests
f81f94c8
lubieowoce test: fix debug log
f26cce64
lubieowoce test: more debug logs (i'm so tired)
bda9e87f
lubieowoce test: timeout... maybe...
205d4e93
lubieowoce test: separate flaky test into two files
59b394a4
lubieowoce test: use next.render()
7f5fe886
lubieowoce test: random port in custom server
12c9bbda
lubieowoce test: remove useless logs
5b1842c5
lubieowoce test: ACTUALLY skip the custom server test in deploy
63e255d9
lubieowoce fix(next-start): close http server before running NextServer cleanups
8030f7fa
lubieowoce lubieowoce force pushed to 8030f7fa 1 year ago
wyattjoh
wyattjoh approved these changes on 2024-11-27
lubieowoce lubieowoce merged 4055dd0c into canary 1 year ago
lubieowoce lubieowoce deleted the lubieowoce/waituntil-before-server-exit branch 1 year ago
github-actions github-actions added locked
github-actions github-actions locked as resolved and limited conversation to collaborators 1 year ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone