next.js
Disallow multiple server directives at the same level (file or function)
#73018

Merged

Disallow multiple server directives at the same level (file or function) #73018

unstubbable merged 8 commits into canary from hl/disallow-multiple-directives-at-same-level

ijjk added created-by: Next.js team

ijjk added Turbopack

unstubbable force pushed from f7442aa6 to a532cf3e 1 year ago

unstubbable marked this pull request as ready for review 1 year ago

unstubbable force pushed from 4bf7dc83 to 1fc58181 1 year ago

unstubbable force pushed from 1fc58181 to ca1e8bb9 1 year ago

unstubbable requested a review from

lubieowoce 1 year ago

lubieowoce commented on 2024-11-22

unstubbable force pushed from ca1e8bb9 to 040eab80 1 year ago

unstubbable force pushed from 040eab80 to 04e715ed 1 year ago

Disallow multiple server directives at the same level (file or function)

bd683df8

Extract `get_directive_for_stmt` function

2f4f587e

Use `get_directive_for_stmt` for module directives

d79dea9c

Add test fixtures for directive in parantheses check

3da4aa6a

Add test fixtures for conflicting directives

559dc5c7

Remove unnecessary dereferences

9bda36d5

Use a `DirectiveVisitor` struct to encapsulate stmt iteration state

a78a3ff7

Use a boolean instead of passing `&self.file_directive`

fd5dc5f4

unstubbable force pushed from 04e715ed to fd5dc5f4 1 year ago

lubieowoce approved these changes on 2024-11-22

unstubbable merged 04adb764 into canary 1 year ago

unstubbable deleted the hl/disallow-multiple-directives-at-same-level branch 1 year ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 1 year ago

Reviewers

lubieowoce

Assignees

No one assigned

Labels

created-by: Next.js team Turbopack locked

Milestone

No milestone