next.js
Unused `searchParams` in `"use cache"` page should not cause dynamic
#75662

Merged

Unused `searchParams` in `"use cache"` page should not cause dynamic #75662

unstubbable merged 15 commits into canary from hl/nar-85

ijjk added created-by: Next.js team

ijjk added type: next

unstubbable force pushed from d40c6b94 to f1ea005e 1 year ago

unstubbable force pushed from 8d6118a9 to d66414cf 1 year ago

unstubbable changed the base branch from canary to hl/use-cache-static-expectations 1 year ago

ijjk added tests

unstubbable force pushed from d66414cf to d6010499 1 year ago

unstubbable changed the title ~~WIP: `"use cache"` page should not cause dynamic~~ Unused `searchParams` in `"use cache"` page should not cause dynamic 1 year ago

unstubbable marked this pull request as ready for review 1 year ago

gnoff commented on 2025-02-05

unstubbable changed the base branch from hl/use-cache-static-expectations to graphite-base/75662 1 year ago

WIP: `"use cache"` page should not cause dynamic

a7b0aaab

Limit condition to when `dynamicIO` is not enabled

3e2e9183

Work around frozen props in dev mode

60adb737

Update prerender test expectation

f75e923f

Improve code comment

98d8fe76

Make `dynamicIOEnabled` property in `WorkStore` required

8e299a61

Always throw an error on access

10aaf426

Don't check for `.then` as that already triggers dynamic

85f27f5f

Add an e2e test

e697fced

Fix expectations

12b4eabc

Replace heuristic with special `$$isPageComponent` prop

b0dcb828

Already pass in empty `searchParams` instead of overwriting

7dbb5b0d

Add missing `dynamicIO` condition

7a023421

Check for `null`

0c6caf81

unstubbable changed the base branch from graphite-base/75662 to canary 1 year ago

Use `wellKnownProperties`

6de131b1

unstubbable force pushed to 6de131b1 1 year ago

gnoff approved these changes on 2025-02-05

unstubbable enabled auto-merge (squash) 1 year ago

unstubbable merged ae5026a0 into canary 1 year ago

unstubbable deleted the hl/nar-85 branch 1 year ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 352 days ago

Reviewers

gnoff

Assignees

No one assigned

Labels

type: next created-by: Next.js team locked tests

Milestone

No milestone

next.js Unused `searchParams` in `"use cache"` page should not cause dynamic #75662 Merged

Unused `searchParams` in `"use cache"` page should not cause dynamic #75662

next.js
Unused `searchParams` in `"use cache"` page should not cause dynamic
#75662

Merged