next.js
[dev-overlay] sync suffix `N` of `--size-N` with `px` value of base font `16px`
#76384

Merged

[dev-overlay] sync suffix `N` of `--size-N` with `px` value of base font `16px` #76384

devjiwonchoi merged 7 commits into canary from 02-23-_dev-overlay_rename_--size-n_css_var_to_--rem-px-n_

ijjk added created-by: Next.js team

ijjk added type: next

devjiwonchoi marked this pull request as ready for review 1 year ago

devjiwonchoi requested a review from

ztanner 1 year ago

devjiwonchoi requested a review from

huozhi 1 year ago

devjiwonchoi requested a review from

eps1lon 1 year ago

devjiwonchoi requested a review from

gaojude 1 year ago

eps1lon commented on 2025-02-23

devjiwonchoi force pushed from a65edc4d 1 year ago

devjiwonchoi force pushed to cfd38a6d 1 year ago

devjiwonchoi changed the title ~~[dev-overlay] rename `--size-n` css var to `--rem-px-n`~~ [dev-overlay] sync suffix `N` of `--size-N` with `px` value of base font `16px` 1 year ago

devjiwonchoi requested a review from

eps1lon 1 year ago

devjiwonchoi force pushed from f4db38cc 1 year ago

huozhi commented on 2025-02-25

huozhi approved these changes on 2025-02-25

[dev-overlay] rename `--size-n` css var to `--rem-px-n`

55da3e64

refine comment

d018f8ca

missed --size-0_5

46afb897

use --size

313f97f1

no vars var

3af189ce

add comments

b2310bb1

fix: --size-gap was removed but still used

5724ad6b

devjiwonchoi force pushed to 5724ad6b 1 year ago

devjiwonchoi merged faae7019 into canary 1 year ago

devjiwonchoi deleted the 02-23-_dev-overlay_rename_--size-n_css_var_to_--rem-px-n_ branch 1 year ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 1 year ago

Reviewers

huozhi

eps1lon

ztanner

gaojude

Assignees

No one assigned

Labels

type: next created-by: Next.js team locked

Milestone

No milestone

next.js [dev-overlay] sync suffix `N` of `--size-N` with `px` value of base font `16px` #76384 Merged

[dev-overlay] sync suffix `N` of `--size-N` with `px` value of base font `16px` #76384

next.js
[dev-overlay] sync suffix `N` of `--size-N` with `px` value of base font `16px`
#76384

Merged