next.js
bugfix: Bad `next.route` on `pages` dir OTel spans for `404`s / `500`s
#77150
Merged

bugfix: Bad `next.route` on `pages` dir OTel spans for `404`s / `500`s #77150

evankirkiles
ijjk ijjk added tests
ijjk ijjk added type: next
ijjk
evankirkiles evankirkiles marked this pull request as ready for review 1 year ago
evankirkiles evankirkiles changed the title Do not overwrite `next.route` root span name with `/400`, `/500`, or `/_error` Do not overwrite `next.route` on root span with `/400`, `/500`, or `/_error` 1 year ago
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles evankirkiles changed the title Do not overwrite `next.route` on root span with `/400`, `/500`, or `/_error` Do not overwrite `next.route` on root span 1 year ago
evankirkiles evankirkiles changed the title Do not overwrite `next.route` on root span bugfix: Incorrect `next.route` on spans for `404`s and `500`s 1 year ago
evankirkiles evankirkiles changed the title bugfix: Incorrect `next.route` on spans for `404`s and `500`s bugfix: Bad `next.route` on OTel spans for `404`s and `500`s 1 year ago
ijjk
ijjk
evankirkiles
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles evankirkiles changed the title bugfix: Bad `next.route` on OTel spans for `404`s and `500`s bugfix: Bad `next.route` on `pages` dir OTel spans for `404`s / `500`s 1 year ago
evankirkiles evankirkiles force pushed 1 year ago
devjiwonchoi devjiwonchoi assigned devjiwonchoi devjiwonchoi 1 year ago
evankirkiles evankirkiles force pushed 1 year ago
vercel
vercel commented on 2025-08-05
evankirkiles
devjiwonchoi
vercel
vercel commented on 2025-08-05
devjiwonchoi devjiwonchoi added CI approved
devjiwonchoi
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles evankirkiles force pushed 1 year ago
evankirkiles Do not overwrite `next.route` on root span if present
6b2f5b96
evankirkiles Use route matcher's pathname for app route spans, not manual derivation
8a8ebcc3
evankirkiles Change `/404` span name in tests to (newer) `/_not-found`
60309a96
evankirkiles Re-add `isNextDev`
447331ed
evankirkiles Make sort order deterministic
729d43e8
evankirkiles Fix span sort order to match deterministic order
50efa3cc
evankirkiles Update tests for new 5xx's as erroring spans behavior
1ca0dc72
evankirkiles Add missing (duplicate) /500 span to expected test result in `start`
f5512e3b
evankirkiles evankirkiles force pushed to f5512e3b 1 year ago
evankirkiles evankirkiles requested a review from devjiwonchoi devjiwonchoi 1 year ago
evankirkiles
devjiwonchoi
devjiwonchoi approved these changes on 2025-08-29
devjiwonchoi devjiwonchoi merged 94414f78 into canary 1 year ago
devjiwonchoi
github-actions github-actions added locked
github-actions github-actions locked as resolved and limited conversation to collaborators 1 year ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
Milestone