next.js
Require that `turbo_tasks::value_trait` items be annotated with `turbo-tasks::function`
#79178

Merged

Require that `turbo_tasks::value_trait` items be annotated with `turbo-tasks::function` #79178

lukesandberg merged 12 commits into canary from required_function_annotation

ijjk added created-by: Turbopack team

ijjk added Turbopack

lukesandberg changed the title ~~Require that value_trait items be annotated with `turbo-tasks::function`~~ Require that `turbo_tasks::value_trait` items be annotated with `turbo-tasks::function` 327 days ago

lukesandberg requested a review from

bgw 327 days ago

lukesandberg marked this pull request as ready for review 327 days ago

lukesandberg commented on 2025-05-14

bgw approved these changes on 2025-05-15

lukesandberg force pushed from fac5dfe1 to 1e008d03 325 days ago

lukesandberg force pushed from 1e008d03 to dfe5373e 312 days ago

lukesandberg force pushed from dfe5373e to d1bd880b 301 days ago

lukesandberg force pushed from d1bd880b to a947cb31 300 days ago

lukesandberg force pushed from 4ef6eb3f to f2d1a404 299 days ago

Require that value_trait items be annotated with `turbo-tasks::function`

243f2d22

Add a ast-grep rewrite rule for adding turbotask function annotations…

5a5e2c71

remove the `function` attributes when generating the value_trait, thi…

bb396425

turns out traits can have default implementations

0f6c13d2

Add annotations to all `value_trait` implementations

bff1700c

move a function to a better shared location and add some docs

6c16633a

lol comment

8cd92e1c

add a try build test for our newly required annotations

61b3ea51

delete the AST grep rule

208b297f

Update value_trait_macro.rs

bbd5eca7

that that

2398ec17

simplify error handling

04e38de6

lukesandberg force pushed from a4d3f805 to 04e38de6 299 days ago

lukesandberg merged 041c9413 into canary 299 days ago

lukesandberg deleted the required_function_annotation branch 299 days ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 276 days ago

Reviewers

bgw

Assignees

No one assigned

Labels

Turbopack created-by: Turbopack team locked

Milestone

No milestone

next.js Require that `turbo_tasks::value_trait` items be annotated with `turbo-tasks::function` #79178 Merged

Require that `turbo_tasks::value_trait` items be annotated with `turbo-tasks::function` #79178

next.js
Require that `turbo_tasks::value_trait` items be annotated with `turbo-tasks::function`
#79178

Merged