next.js
Store keys in key order in SST blocks that omit hashes
#97480

Merged

Store keys in key order in SST blocks that omit hashes #97480

lukesandberg merged 13 commits into canary from hashes_are_a_write_time_optimization_read_time_pessimisation

lukesandberg commented on 2026-08-18

lukesandberg requested a review from

sokra 10 days ago

lukesandberg marked this pull request as ready for review 10 days ago

lukesandberg commented on 2026-08-20

lukesandberg enabled auto-merge (squash) 10 days ago

lukesandberg force pushed from cce71159 to d497b395 9 days ago

disabled auto-merge 9 days ago
Manually disabled by user

lukesandberg force pushed from d497b395 to b8a15b58 6 days ago

lukesandberg commented on 2026-08-28

wbinnssmith approved these changes on 2026-08-28

Store keys in key order in SST blocks that omit hashes

99a22e6a

Simplify key-order sort in StreamingSstWriter

e1f2a8f4

Make StoreKey/Entry expose key bytes directly

83974b1d

Simplify block key sort to a single sort_by

09feaf23

fix a missing storekey impl

498987b6

Specialize the block key sort on uniform key length

efac8272

Address code review findings

0f4a4b7a

Test that key ordering preserves block and file counts

cd9dd695

Address max-effort code review findings

c98db883

simplify comments

a037b175

more simplifications

8d46fbf8

d591de14

address review feedback

d639f13e

lukesandberg force pushed from b8a15b58 to d639f13e 2 days ago

lukesandberg merged 33a5d542 into canary 2 days ago

lukesandberg deleted the hashes_are_a_write_time_optimization_read_time_pessimisation branch 2 days ago

Reviewers

wbinnssmith

sokra

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

next.js Store keys in key order in SST blocks that omit hashes #97480 Merged

Store keys in key order in SST blocks that omit hashes #97480

next.js
Store keys in key order in SST blocks that omit hashes
#97480

Merged