next.js
Prefer using join over try_join when you don't want a vec
#98547

Merged

Prefer using join over try_join when you don't want a vec #98547

lukesandberg merged 7 commits into canary from try_join_enhancement

lukesandberg changed the title ~~try-join bro~~ enhance the try_join api to remove some allocations 62 days ago

lukesandberg commented on 2026-09-11

lukesandberg force pushed from 35636ff8 to 578e848f 62 days ago

lukesandberg requested a review from

mischnic 62 days ago

lukesandberg marked this pull request as ready for review 62 days ago

lukesandberg force pushed from 66c14164 to c7109737 60 days ago

mischnic commented on 2026-09-14

lukesandberg force pushed from c7109737 to a7271caa 59 days ago

lukesandberg changed the title ~~enhance the try_join api to remove some allocations~~ Prefer using join over try_join when you don't want a vec 59 days ago

bgw approved these changes on 2026-09-14

lukesandberg changed the base branch from tiny_memory_fixes to canary 58 days ago

lukesandberg force pushed from 4dc917a9 to 7bce16ef 58 days ago

try-join bro

e59a172d

fix the clip

b613c132

Drop try_join_for_each helpers in favor of direct iteration

896cce1e

Drop try_join_collect helpers in favor of standard iterator helpers

b204e8df

Use join instead of try_join where results are only drained once

4375c837

Use flatten_ok for the two nested join sites

4481b092

remove a pointless comment

042e2a8e

lukesandberg force pushed from 7bce16ef to 042e2a8e 58 days ago

mischnic approved these changes on 2026-09-16

lukesandberg merged 16c8ea5d into canary 57 days ago

lukesandberg deleted the try_join_enhancement branch 57 days ago

github-actions added locked

github-actions locked as resolved and limited conversation to collaborators 43 days ago

Reviewers

mischnic

bgw

Assignees

No one assigned

Labels

locked

Milestone

No milestone

next.js Prefer using join over try_join when you don't want a vec #98547 Merged

Prefer using join over try_join when you don't want a vec #98547

next.js
Prefer using join over try_join when you don't want a vec
#98547

Merged