Send task summaries as tasks finish #4913
mehulkar
merged
60 commits into
main
from
mehulkar/turbo-916-runs-send-task-summaries-as-tasks-finish
Create spacesClient struct to make requests to spaces
5855a251
Post run start at the beginning of the run
d3efd089
Close/POST tasks as they finish
9c049876
Remove wrapper method for PATCH request
f8bdc263
Remove api client from runsummary struct, only used by spaces client
87647e0a
Move constants to the file they are used in
d9e77750
Put all errors in the same place, no need to distinguish
02bef6ab
Make requests via a goroutine and wait on all requests to be done
dcf3001c
Add another error condition
195116e9
Make unlinked error generic and consolidate to one place
ea92a70a
Always decrement waitgroup counter if we're throwing away request
0d17035e
Make error/help message for linking better
a1cc4da3
Better error method
8e60c590
Remove extranneous check
26480f36
Move erorr making to req struct instance
dedb97ee
Consistent error and debug messages
5f59f5d2
Lazily compute req urls and set response on onDone handler
1601f992
Block all requests on the first run POST request
39d7e89b
Shuffle methods around for readability
d05ea232
give spacesClient access to rsm
b67511b2
Consolidate error msg when there is no spaceId
37a183c5
Remove redundant check for runID when posting tasks
c7ee5b37
Better comments
d96d4b15
Standardized error message
50d1adfa
check for run id first so error messages wont be duplicated
d24bec75
Parallelize requests into 8 goroutines
be6c9cd5
Use a single wait group
e3cb1448
reduce diff
c98a04f8
remove unnecessary wrapper method
d74acd86
Move the signal internal to spaceRun
9722fe8d
TODO notes
c6c44397
wait for run create channel to close as new requests come in, not before
46382dce
Use req.error for unmarshal error
ff223fe4
Remove error return, we just log errors
2e912298
rearrange
03f4d789
make explicit start()
2260f6d3
Make requests in goroutine so they are not blocking when they do star…
867e4c41
comments
95a9c63c
Use Duration method instead of manually calculating duration
73e354ab
move spaceID into spacesClient struct
abeab8f4
Skip all requests if there is no spaceId
0d41fea5
Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-…
72d1457d
Remove bidirectional relationship
580255e8
better comments
c1bb83a8
Fix goroutine setup for async task requests (#4924)
0159de90
Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-…
01a38609
Wait for requests to complete before closing channel
62041c0c
separate data from resources
6a454db8
Improve code comments
7b3b6633
Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-…
2f6521af
Remove unused field
f771e8ba
mehulkar
commented
on 2023-05-16
Merge branch 'main' into mehulkar/turbo-916-runs-send-task-summaries-…
c9174ec8
Check whether spaces is enabled earlier and fewer times
eb30ac35
remove extranneous check for spaceId
682630fe
use .enabled consistently
cf4e598a
Check for linked repo once and disable client if no link
19376548
Print errors when disabled
8e8085cd
nothing
ae3d8d6f
Handle edge case of channel being closed before the reuqest is done
1393df57
only add error for missing link if spaces is enabled
110bcd83
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub