๐ Hi! Thank you for contributing to the vLLM project.
๐ฌ Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck
CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck
build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo
or khluu
to add you in our Buildkite org.
Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.
To run CI, PR reviewers can either: Add ready
label to the PR or enable auto-merge.
๐
LGTM, thanks for improving the confusing error!
Login to write a write a comment.
Background
The
--model
option (no need in vllm serve) accepts either a Hugging Face (HF) repo ID or a local path. Currently, two confusing scenarios occur:Local Path:
When a non-existent local path (e.g.,
"/xxx/xxx"
) is provided, an error is raised at this line. The error message,misleadingly suggests that the input should be an HF repo ID.
HF Repo ID:
When a non-existent HF repo ID (e.g.,
"xxx/xxx"
, without a leading/
) is provided, the error does not occur immediately at this line. Instead, it fails later in the code, as described in issue #13510.Changes
This PR unifies error handling for both cases by:
Example Usage