vllm
[Bugfix] Treat generation_config max_tokens as default not ceiling
#34063
Merged

[Bugfix] Treat generation_config max_tokens as default not ceiling #34063

almogtavor
almogtavor fix: treat generation_config max_tokens as default, not ceiling (#34005)
f103fb04
almogtavor almogtavor requested a review from DarkLight1337 DarkLight1337 94 days ago
almogtavor almogtavor requested a review from robertgshaw2-redhat robertgshaw2-redhat 94 days ago
almogtavor almogtavor requested a review from aarnphm aarnphm 94 days ago
almogtavor almogtavor requested a review from NickLucche NickLucche 94 days ago
almogtavor almogtavor requested a review from chaunceyjiang chaunceyjiang 94 days ago
mergify mergify added frontend
mergify mergify added bug
gemini-code-assist
gemini-code-assist commented on 2026-02-07
mergify
DarkLight1337
DarkLight1337 commented on 2026-02-08
almogtavor refactor: rename variables in get_max_tokens for clarity
a22bcc49
DarkLight1337
DarkLight1337 approved these changes on 2026-02-09
DarkLight1337 DarkLight1337 enabled auto-merge (squash) 92 days ago
github-actions github-actions added ready
almogtavor Merge branch 'main' into almogtavor/fix-generation-config-max-tokens
65927a8a
almogtavor Merge branch 'main' into almogtavor/fix-generation-config-max-tokens
52f6fc17
DarkLight1337
almogtavor
almogtavor Merge branch 'main' into almogtavor/fix-generation-config-max-tokens
3d2d0168
DarkLight1337
DarkLight1337
almogtavor
DarkLight1337
almogtavor fix: keep the support for the max_tokens override
b25fadbc
disabled auto-merge 90 days ago
Head branch was pushed to by a user without write access
almogtavor almogtavor requested a review from DarkLight1337 DarkLight1337 90 days ago
DarkLight1337
DarkLight1337 commented on 2026-02-12
mobicham
vllm-bot vllm-bot merged 72d5951d into main 85 days ago
almogtavor
mobicham

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone