vllm
[Bugfix][CI/Build] Fix test and improve code for `merge_async_iterators`
#5096
Merged

[Bugfix][CI/Build] Fix test and improve code for `merge_async_iterators` #5096

simon-mo merged 4 commits into vllm-project:main from refactor-tests-1
DarkLight1337
DarkLight13371 year ago (edited 1 year ago)

This PR fixes an issue where merge_async_iterators tests cannot be run in python<3.10 due to lack of anext builtin. It also moves the test to a more appropriate location (test_utils.py).

Functionality-wise, this PR enables async tasks in merge_async_iterators to be cancelled with a message starting from python>=3.9 where it is supported.

Related contributions

This is part 1/5 of #5004.

DarkLight1337 Move `test_merge_async_iterators`
b3ef189d
DarkLight1337 Add polyfill for `anext` for the test to work in Python <3.10
9589a7bc
DarkLight1337 Enable `msg` parameter in `task.cancel` if possible
978ad2c8
DarkLight1337 DarkLight1337 changed the title [Misc][Bugfix] Improve `merge_async_iterators` code and tests [Bugfix] Improve `merge_async_iterators` code and tests 1 year ago
DarkLight1337 DarkLight1337 changed the title [Bugfix] Improve `merge_async_iterators` code and tests [Bugfix][CI/Build] Improve `merge_async_iterators` code and tests 1 year ago
DarkLight1337 Fix undeclared type annotations at runtime
fa102ffb
DarkLight1337 DarkLight1337 changed the title [Bugfix][CI/Build] Improve `merge_async_iterators` code and tests [Bugfix][CI/Build] Fix test and improve code for `merge_async_iterators` 1 year ago
simon-mo
simon-mo approved these changes on 2024-05-29
simon-mo simon-mo merged eecd8643 into main 1 year ago
DarkLight1337 DarkLight1337 deleted the refactor-tests-1 branch 1 year ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone