PR #3266 Adding utility handlers to DnD hooks to simplify implementation experience

initial brain storming

LFDanLu committed 4 years ago

adding assumptions, updating stories, fixing bugs

LFDanLu committed 4 years ago

add useDraggable and useDroppable, document other bugs

LFDanLu committed 4 years ago

compiling feedback and tentative implementation some meeting feedback

LFDanLu committed 4 years ago

switching to single hook strategy

LFDanLu committed 4 years ago

cleaning up some testing code

LFDanLu committed 4 years ago

adding dropOperation to onInsert,onRootDrop, etc

LFDanLu committed 4 years ago

experiementation with tracking draggedCollection and droppedCollection

LFDanLu committed 4 years ago

debugging and musings

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

porting onReorder and other helper functions to the aria dnd hooks

LFDanLu committed 4 years ago

fixing circular dep and adding another story with onDrop/getDropOperation override

LFDanLu committed 4 years ago

debug tests, fixes, and some additional musings

LFDanLu committed 4 years ago

storing dom node as drop target if dropping on non-collection drop target

LFDanLu committed 4 years ago

fixing lint

LFDanLu committed 4 years ago

cleanup

LFDanLu committed 4 years ago

fixing case where getDropOperation is provided but onDrop isnt

LFDanLu committed 4 years ago

fix case where onDrop is defined but getDropOperation isnt

LFDanLu committed 4 years ago

updating ListView getDropTargetFromPoint so it uses dropState.getDropOperation

LFDanLu committed 4 years ago

tentative defaultGetDropTargetFromPoint outline

LFDanLu committed 4 years ago

Revert "tentative defaultGetDropTargetFromPoint outline"

LFDanLu committed 4 years ago

Revert "updating ListView getDropTargetFromPoint so it uses dropState.getDropOperation"

LFDanLu committed 4 years ago

passing items directly to handlers

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

tracking currently dragged keys in global state

LFDanLu committed 4 years ago

making util handlers more consistent with other drop handlers

LFDanLu committed 4 years ago

tracking dragging/dropping collection refs instead of collections

LFDanLu committed 4 years ago

adding isInternalDrop info to onItemDrop

LFDanLu committed 4 years ago

adding onRemove util function

LFDanLu committed 4 years ago

handle onInsert copy operation

LFDanLu committed 4 years ago

restoring delayed onDrop behavior in useDrop

LFDanLu committed 4 years ago

fixing tests to match delayed onDrop

LFDanLu committed 4 years ago

removing useDragHooks and useDropHooks

LFDanLu committed 4 years ago

fixing lint

LFDanLu committed 4 years ago

clean up types and provide more info to isValidDropTarget

LFDanLu committed 4 years ago

delaying onDragEnd handler so it always happens after onDrop

LFDanLu committed 4 years ago

add workaround for Chrome Android bug

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

progress on tests and fixing endDrag

LFDanLu committed 4 years ago

adding tests for the global DnD state tracker

LFDanLu committed 4 years ago

allowing user to perform onInsert in the same list if it is a copy operation

LFDanLu committed 4 years ago

fixing some review comments and bugs

LFDanLu committed 4 years ago

adjusting defaultDrop's dep array so it works with handler updates during drag

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

fix getDropTargetFromPoint so that it accounts for root drop cases

LFDanLu committed 4 years ago

clearing global DnD state in onDrop if drag item isnt a RSP dnd item

LFDanLu committed 4 years ago

revert getDropTargetFromPoint changes

LFDanLu committed 4 years ago

fixing tests and adjusting type

LFDanLu committed 4 years ago

adding filed bug

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

Merge branch 'main' into dnd_api_simplification

LFDanLu committed 4 years ago

making internal copy drop insert operations a no op

LFDanLu committed 4 years ago

move global dnd state to aria/dnd and update getDropOperation

LFDanLu committed 4 years ago

removing droppedTarget tracking from global dnd state

LFDanLu committed 4 years ago

unifying dropCollectionRef tracker in global DnD state

LFDanLu committed 4 years ago

clearing dropCollectionRef when drag is canceled via Escape and tests

LFDanLu committed 4 years ago

allowing drops that have invalid and valid drag types

LFDanLu committed 4 years ago

removing timeout from onDrop

LFDanLu committed 4 years ago

adding useDraggableCollection

LFDanLu committed 4 years ago

adding more storybook actions and fixing when they are fired

LFDanLu committed 4 years ago

making useDnDHooks return a merged list of hooks

LFDanLu committed 4 years ago

forgot to include the story updates

LFDanLu committed 4 years ago

first stab at adding automatic item filtering onDrop

LFDanLu committed 4 years ago

use acceptedDragTypes in default onDrop filtering if provided

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

fixing tests from merge

LFDanLu committed 4 years ago

update prop names to shouldAcceptItemDrop and onItemRemove

LFDanLu committed 4 years ago

fix non draggable ListView

LFDanLu committed 4 years ago

fixing tests in 16 and 17

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

fixing merge and tests

LFDanLu committed 4 years ago

allowing internal copy operation via onReorder, revert to old getDropOperations

LFDanLu committed 4 years ago

fixing tests and adding useDraggableCollection to draggable listbox

LFDanLu committed 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_simplification

LFDanLu committed 4 years ago

refactor global dnd state

LFDanLu committed 4 years ago

fixing drag between list story

LFDanLu committed 4 years ago

adding tests for default onDrop filtering and directory/file dropping

LFDanLu committed 4 years ago

Merge branch 'main' into dnd_api_simplification

LFDanLu committed 4 years ago

adding more stories

LFDanLu committed 4 years ago

use shouldAcceptItemDrop to further filter what items are provided to drop handlers

LFDanLu committed 4 years ago

adding tests for shouldAcceptItemDrop drop filtering

LFDanLu committed 4 years ago

fix skipped test

LFDanLu committed 4 years ago

removing onItemRemove from util handlers

LFDanLu committed 4 years ago

quick fix to detect android talkback click when setting modality

LFDanLu committed 4 years ago

clean up

LFDanLu committed 4 years ago

Merge branch 'main' into dnd_api_simplification

LFDanLu committed 4 years ago

fixing test for 17

LFDanLu committed 4 years ago

improving isVirtualClick detection of Android talkback clicks

LFDanLu committed 4 years ago

fixing lint

LFDanLu committed 4 years ago

removing pointer listener case from android isVirtualClick detection

LFDanLu committed 4 years ago

Merge branch 'main' into dnd_api_simplification

LFDanLu committed 4 years ago

Merge branch 'main' into dnd_api_simplification

LFDanLu committed 4 years ago

react-spectrum Adding utility handlers to DnD hooks to simplify implementation experience #3266 Merged

react-spectrum
Adding utility handlers to DnD hooks to simplify implementation experience
#3266

Merged