PR #3266 Adding utility handlers to DnD hooks to simplify implementation experience

initial brain storming

2df9a375

adding assumptions, updating stories, fixing bugs

5557133d

add useDraggable and useDroppable, document other bugs

1e349c65

compiling feedback and tentative implementation some meeting feedback

3c2fe80d

switching to single hook strategy

fa403e0d

cleaning up some testing code

28a4ffae

adding dropOperation to onInsert,onRootDrop, etc

d307c8ea

experiementation with tracking draggedCollection and droppedCollection

eb7a2d34

debugging and musings

3f632a57

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

ba3e1959

porting onReorder and other helper functions to the aria dnd hooks

652bbb38

fixing circular dep and adding another story with onDrop/getDropOpera…

90309cd8

debug tests, fixes, and some additional musings

2c22dc8c

storing dom node as drop target if dropping on non-collection drop ta…

bee815a1

fixing lint

674b0777

cleanup

6d43c5bc

fixing case where getDropOperation is provided but onDrop isnt

4785f911

fix case where onDrop is defined but getDropOperation isnt

f939a8fe

LFDanLu commented on 2022-07-29

updating ListView getDropTargetFromPoint so it uses dropState.getDrop…

0f8c96be

tentative defaultGetDropTargetFromPoint outline

faae38bf

Revert "tentative defaultGetDropTargetFromPoint outline"

d70d5cf2

Revert "updating ListView getDropTargetFromPoint so it uses dropState…

711cd8ee

passing items directly to handlers

07997fef

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

2e8d282c

tracking currently dragged keys in global state

0f5f6b23

making util handlers more consistent with other drop handlers

0b0627e7

tracking dragging/dropping collection refs instead of collections

8d2d015f

adding isInternalDrop info to onItemDrop

46095975

adding onRemove util function

db24257f

handle onInsert copy operation

cd820151

restoring delayed onDrop behavior in useDrop

283a15f7

fixing tests to match delayed onDrop

91c45af4

removing useDragHooks and useDropHooks

c25a2f18

fixing lint

1f22942c

LFDanLu commented on 2022-08-05

clean up types and provide more info to isValidDropTarget

ac5912ca

delaying onDragEnd handler so it always happens after onDrop

41971046

add workaround for Chrome Android bug

4b5a0a23

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

c71decea

progress on tests and fixing endDrag

fbbb5f85

adding tests for the global DnD state tracker

0f10c936

LFDanLu marked this pull request as ready for review 3 years ago

LFDanLu changed the title ~~(WIP) Dnd api simplification~~ Dnd api simplification 3 years ago

allowing user to perform onInsert in the same list if it is a copy op…

900c2751

fixing some review comments and bugs

c0807704

adjusting defaultDrop's dep array so it works with handler updates du…

66e6b87c

LFDanLu commented on 2022-08-16

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

6fc10d55

fix getDropTargetFromPoint so that it accounts for root drop cases

87d27855

clearing global DnD state in onDrop if drag item isnt a RSP dnd item

fa7d2947

revert getDropTargetFromPoint changes

db01fef3

fixing tests and adjusting type

227c559a

adding filed bug

c0cbe420

LFDanLu commented on 2022-08-18

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

c7e4db43

Merge branch 'main' into dnd_api_simplification

0a9262f6

LFDanLu commented on 2022-08-29

making internal copy drop insert operations a no op

c78af275

move global dnd state to aria/dnd and update getDropOperation

9cf11b94

removing droppedTarget tracking from global dnd state

b239afe5

unifying dropCollectionRef tracker in global DnD state

d2c61bec

clearing dropCollectionRef when drag is canceled via Escape and tests

2bc36791

allowing drops that have invalid and valid drag types

5d6f7aee

removing timeout from onDrop

500b6897

adding useDraggableCollection

a1241263

adding more storybook actions and fixing when they are fired

8eaeadbe

making useDnDHooks return a merged list of hooks

07d07ef3

forgot to include the story updates

6971b106

first stab at adding automatic item filtering onDrop

419e79d7

LFDanLu commented on 2022-09-02

use acceptedDragTypes in default onDrop filtering if provided

c4b3c5f0

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

80051ec2

fixing tests from merge

8f6b7bcb

update prop names to shouldAcceptItemDrop and onItemRemove

d6319708

fix non draggable ListView

f601b18e

LFDanLu changed the title ~~Dnd api simplification~~ (WIP) Dnd api simplification 3 years ago

devongovett commented on 2022-09-07

fixing tests in 16 and 17

545cb66b

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

f8066799

fixing merge and tests

8903e369

allowing internal copy operation via onReorder, revert to old getDrop…

41de3def

fixing tests and adding useDraggableCollection to draggable listbox

7924c2d6

Merge branch 'main' of github.com:adobe/react-spectrum into dnd_api_s…

05cffed6

refactor global dnd state

3e7f92c2

fixing drag between list story

d5f37071

adding tests for default onDrop filtering and directory/file dropping

616c8542

Merge branch 'main' into dnd_api_simplification

c01363e4

adding more stories

034a8485

use shouldAcceptItemDrop to further filter what items are provided to…

96f765a9

adding tests for shouldAcceptItemDrop drop filtering

fdc0656b

fix skipped test

02089861

removing onItemRemove from util handlers

73c0c627

quick fix to detect android talkback click when setting modality

92edd2bf

LFDanLu commented on 2022-09-15

clean up

225dd610

Merge branch 'main' into dnd_api_simplification

8f755663

LFDanLu changed the title ~~(WIP) Dnd api simplification~~ Dnd api simplification 3 years ago

LFDanLu changed the title ~~Dnd api simplification~~ Adding utility handlers to DnD hooks to simplify implementation experience 3 years ago

LFDanLu commented on 2022-09-15

fixing test for 17

7debb090

improving isVirtualClick detection of Android talkback clicks

c95ea692

fixing lint

f887501f

LFDanLu commented on 2022-09-15

devongovett commented on 2022-09-16

removing pointer listener case from android isVirtualClick detection

796ec992

devongovett commented on 2022-09-17

devongovett commented on 2022-09-19

Merge branch 'main' into dnd_api_simplification

ad58545b

devongovett approved these changes on 2022-09-20

reidbarber approved these changes on 2022-09-20

Merge branch 'main' into dnd_api_simplification

dafd2869

LFDanLu merged 2851cbd1 into main 3 years ago

LFDanLu deleted the dnd_api_simplification branch 3 years ago

adobe deleted a comment from ghost on 2022-09-20

react-spectrum
Adding utility handlers to DnD hooks to simplify implementation experience
#3266

Merged

Adding utility handlers to DnD hooks to simplify implementation experience #3266

react-spectrum Adding utility handlers to DnD hooks to simplify implementation experience #3266 Merged

Adding utility handlers to DnD hooks to simplify implementation experience #3266

react-spectrum
Adding utility handlers to DnD hooks to simplify implementation experience
#3266

Merged