react-spectrum
Fix overlay position clamping and arrow position
#4220
Merged
Overview
Commits
37
Changes
View On GitHub

Fix overlay position clamping and arrow position #4220

devongovett merged 37 commits into main from update_overlay_pos
LFDanLu
filipw01 Fix overlay position clamping
62be226c
filipw01 Add tests and update test data
209e353d
snowystinger Merge branch 'main' into main
77b015ef
snowystinger Merge branch 'main' into main
11a08cad
LFDanLu Merge branch 'main' into main
57dec707
filipw01 Merge branch 'adobe:main' into main
586aa36d
filipw01 Fix arrow position and clamping value
df3eb71d
filipw01 Add arrowCrossSize option to useOverlayPosition
f3f3f174
filipw01 Update tests
f2cba0ec
filipw01 Adapt Popover to use arrowCrossSize option
e7a4c5d0
LFDanLu Merge branch 'main' into main
c0e7ca78
LFDanLu Adding DialogTrigger story with controls for testing
9fb264b4
filipw01 Add arrowTotalCrossPadding
d7c9d56c
LFDanLu Merge branch 'main' into main
2131832e
filipw01 Get border-radius from the DOM
d88ba5fc
filipw01 Get tooltip arrow size from the DOM
147796e2
LFDanLu Merge branch 'main' into main
1d5dc096
filipw01 Don't leave place for overlap when arrow hidden
c441837e
filipw01 Merge branch 'main' into main
f537e676
LFDanLu Fixing DialogTrigger stories so they use the new controls
3702ea86
LFDanLu Merge branch 'main' into main
ffffa67d
LFDanLu update position logic calculations and properly get the tooltip arrow…
0c41d232
LFDanLu update tests to reflect that middle of button arrow tip positioning p…
c86dc14c
LFDanLu
LFDanLu commented on 2023-03-17
rspbot
LFDanLu
LFDanLu commented on 2023-03-17
snowystinger
snowystinger commented on 2023-03-17
LFDanLu removing extra space
c55692f7
rspbot
LFDanLu update overlay postioning
f6dede06
LFDanLu adding tests for min overlay arrow offset
3e73b3ba
rspbot
LFDanLu LFDanLu changed the title (WIP) Fix overlay position clamping and arrow position Fix overlay position clamping and arrow position 2 years ago
LFDanLu update positioning logic to move the arrow as close to the center of …
1f3886f1
rspbot
LFDanLu add chromatic tests
89cc2eb4
rspbot
LFDanLu
snowystinger
snowystinger commented on 2023-03-21
filipw01
ktabors
ktabors
ktabors commented on 2023-03-22
LFDanLu LFDanLu added release
LFDanLu address reviews
b525bae8
LFDanLu fix lint
b3246bba
rspbot
snowystinger Merge branch 'main' into update_overlay_pos
4ee8c57a
snowystinger
snowystinger approved these changes on 2023-03-22
rspbot
LFDanLu LFDanLu added ready for review
LFDanLu Merge branch 'main' into update_overlay_pos
26833875
LFDanLu
rspbot
LFDanLu Merge branch 'main' into update_overlay_pos
d65b8cc5
rspbot
LFDanLu Merge branch 'main' into update_overlay_pos
24233805
snowystinger Merge branch 'main' into update_overlay_pos
e9c8f3ad
rspbot
rspbot
snowystinger Merge branch 'main' into update_overlay_pos
fdff36c0
rspbot
devongovett
devongovett approved these changes on 2023-03-23
LFDanLu Merge branch 'main' into update_overlay_pos
7c00f2c0
rspbot
rspbot
devongovett devongovett merged a8bc2b13 into main 2 years ago
devongovett devongovett deleted the update_overlay_pos branch 2 years ago
reidbarber reidbarber removed ready for review
snowystinger snowystinger removed release

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum