PR #33200 🚨🚨🚨 [SuperPoint] Fix keypoint coordinate output and add post processing

feat: Added int conversion and unwrapping

Steven Bucaille committed 2 years ago

test: added tests for post_process_keypoint_detection of SuperPointImageProcessor

sbucaille committed 2 years ago

docs: changed docs to include post_process_keypoint_detection method and switched from opencv to matplotlib

sbucaille committed 2 years ago

test: changed test to not depend on SuperPointModel forward

sbucaille committed 2 years ago

test: added missing require_torch decorator

sbucaille committed 2 years ago

docs: changed pyplot parameters for the keypoints to be more visible in the example

sbucaille committed 2 years ago

tests: changed import torch location to make test_flax and test_tf

sbucaille committed 2 years ago

Revert "tests: changed import torch location to make test_flax and test_tf"

sbucaille committed 2 years ago

tests: fixed import

sbucaille committed 2 years ago

chore: applied suggestions from code review

sbucaille committed 2 years ago

tests: fixed import

sbucaille committed 2 years ago

tests: fixed import (bis)

sbucaille committed 2 years ago

tests: fixed import (ter)

sbucaille committed 2 years ago

feat: added choice of type for target_size and changed tests accordingly

sbucaille committed 2 years ago

docs: updated code snippet to reflect the addition of target size type choice in post process method

sbucaille committed 2 years ago

tests: fixed imports (...)

Steven Bucaille committed 2 years ago

tests: fixed imports (...)

Steven Bucaille committed 2 years ago

style: formatting file

Steven Bucaille committed 2 years ago

docs: fixed typo from image[0] to image.size[0]

sbucaille committed 2 years ago

docs: added output image and fixed some tests

sbucaille committed 2 years ago

Update docs/source/en/model_doc/superpoint.md

sbucaille committed 1 year ago

fix: included SuperPointKeypointDescriptionOutput in TYPE_CHECKING if statement and changed tests results to reflect changes to SuperPoint from absolute keypoints coordinates to relative

sbucaille committed 1 year ago

docs: changed SuperPoint's docs to print output instead of just accessing

sbucaille committed 1 year ago

style: applied make style

sbucaille committed 1 year ago

docs: added missing output type and precision in docstring of post_process_keypoint_detection

sbucaille committed 1 year ago

perf: deleted loop to perform keypoint conversion in one statement

sbucaille committed 1 year ago

fix: moved keypoint conversion at the end of model forward

sbucaille committed 1 year ago

docs: changed SuperPointInterestPointDecoder to SuperPointKeypointDecoder class name and added relative (x, y) coordinates information to its method

sbucaille committed 1 year ago

fix: changed type hint

sbucaille committed 1 year ago

refactor: removed unnecessary brackets

sbucaille committed 1 year ago

revert: SuperPointKeypointDecoder to SuperPointInterestPointDecoder

sbucaille committed 1 year ago

Update docs/source/en/model_doc/superpoint.md

sbucaille committed 1 year ago

transformers 🚨🚨🚨 [SuperPoint] Fix keypoint coordinate output and add post processing #33200 Merged

transformers
🚨🚨🚨 [SuperPoint] Fix keypoint coordinate output and add post processing
#33200

Merged