transformers
🚨🚨🚨 [SuperPoint] Fix keypoint coordinate output and add post processing
#33200
Merged

🚨🚨🚨 [SuperPoint] Fix keypoint coordinate output and add post processing #33200

qubvel merged 32 commits into huggingface:main from sbucaille:superpoint_fix
sbucaille
feat: Added int conversion and unwrapping
17d50e88
amyeroberts
amyeroberts commented on 2024-08-29
sbucaille test: added tests for post_process_keypoint_detection of SuperPointIm…
285c465b
sbucaille docs: changed docs to include post_process_keypoint_detection method …
2efe61b5
sbucaille test: changed test to not depend on SuperPointModel forward
a77b8705
sbucaille test: added missing require_torch decorator
2ab79cdc
sbucaille docs: changed pyplot parameters for the keypoints to be more visible …
419ae5dc
sbucaille tests: changed import torch location to make test_flax and test_tf
39b32a2f
sbucaille Revert "tests: changed import torch location to make test_flax and te…
144e09a2
sbucaille tests: fixed import
21dbdfc0
NielsRogge
NielsRogge commented on 2024-09-01
NielsRogge
NielsRogge commented on 2024-09-01
merveenoyan
merveenoyan commented on 2024-09-01
sbucaille chore: applied suggestions from code review
389b154d
sbucaille tests: fixed import
b7d672e9
sbucaille tests: fixed import (bis)
f5d73118
sbucaille tests: fixed import (ter)
d89d3854
sbucaille feat: added choice of type for target_size and changed tests accordingly
f9e11412
sbucaille docs: updated code snippet to reflect the addition of target size typ…
32a2e96a
tests: fixed imports (...)
560194e8
tests: fixed imports (...)
2d28aba5
style: formatting file
bd23baa6
NielsRogge NielsRogge requested a review from amyeroberts amyeroberts 1 year ago
merveenoyan
merveenoyan commented on 2024-09-02
sbucaille docs: fixed typo from image[0] to image.size[0]
5bb0baf0
amyeroberts
amyeroberts commented on 2024-09-05
sbucaille docs: added output image and fixed some tests
ed28314b
sbucaille
HuggingFaceDocBuilderDev
qubvel qubvel requested a review from qubvel qubvel 1 year ago
qubvel
qubvel
qubvel commented on 2024-10-02
sbucaille Update docs/source/en/model_doc/superpoint.md
192448d0
sbucaille fix: included SuperPointKeypointDescriptionOutput in TYPE_CHECKING if…
e89af7f8
sbucaille docs: changed SuperPoint's docs to print output instead of just acces…
4e77a4fe
sbucaille style: applied make style
e9b642ab
sbucaille
qubvel qubvel added Vision
qubvel qubvel added bug
qubvel qubvel changed the title [SuperPoint] Fix keypoint coordinate output and add post processing 🚨🚨🚨 [SuperPoint] Fix keypoint coordinate output and add post processing 1 year ago
qubvel
qubvel commented on 2024-10-03
sbucaille docs: added missing output type and precision in docstring of post_pr…
e0858611
sbucaille perf: deleted loop to perform keypoint conversion in one statement
91275455
sbucaille fix: moved keypoint conversion at the end of model forward
1ffa4659
sbucaille docs: changed SuperPointInterestPointDecoder to SuperPointKeypointDec…
b0d25a35
sbucaille fix: changed type hint
1fb5705d
qubvel
qubvel commented on 2024-10-04
sbucaille refactor: removed unnecessary brackets
13cb7e5b
sbucaille revert: SuperPointKeypointDecoder to SuperPointInterestPointDecoder
eb6a5aad
qubvel qubvel requested a review from qubvel qubvel 1 year ago
qubvel
qubvel commented on 2024-10-04
sbucaille Update docs/source/en/model_doc/superpoint.md
4c34d752
ArthurZucker ArthurZucker requested a review from ArthurZucker ArthurZucker 1 year ago
ArthurZucker
ArthurZucker approved these changes on 2024-10-15
onuralpszr
sbucaille
qubvel qubvel merged a1835195 into main 1 year ago
qubvel
sbucaille sbucaille deleted the superpoint_fix branch 1 year ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone